Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 399173003: [chromedriver] Reenable ParseCapabilities.MobileEmulationDeviceName, since it no longer depends on … (Closed)

Created:
6 years, 5 months ago by samuong
Modified:
6 years, 5 months ago
Reviewers:
stgao
CC:
chromium-reviews, stgao, apavlov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Reenable ParseCapabilities.MobileEmulationDeviceName, since it no longer depends on files generated from Blink sources. BUG=392430 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/chromedriver/capabilities_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
samuong
6 years, 5 months ago (2014-07-17 21:28:17 UTC) #1
stgao
I remember you wanted to remove the dependency on the device list. Do you want ...
6 years, 5 months ago (2014-07-17 21:43:45 UTC) #2
samuong
On 2014/07/17 21:43:45, Shuotao wrote: > I remember you wanted to remove the dependency on ...
6 years, 5 months ago (2014-07-17 21:50:01 UTC) #3
stgao
lgtm But I would still suggest mocking out the list. If the device list is ...
6 years, 5 months ago (2014-07-17 21:57:04 UTC) #4
samuong
On 2014/07/17 21:57:04, Shuotao wrote: > lgtm > > But I would still suggest mocking ...
6 years, 5 months ago (2014-07-17 22:01:44 UTC) #5
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 5 months ago (2014-07-17 22:01:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/399173003/1
6 years, 5 months ago (2014-07-17 22:05:04 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 02:58:53 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 04:17:03 UTC) #9
Message was sent while issue was closed.
Change committed as 284004

Powered by Google App Engine
This is Rietveld 408576698