Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 399173002: Mark hunspell as not chromium code in the GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Mark hunspell as not chromium code in the GN build. It compiles with warnings under clang. TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 5 months ago (2014-07-17 17:52:23 UTC) #1
brettw
Committed patchset #1 manually as r283809 (presubmit successful).
6 years, 5 months ago (2014-07-17 17:52:30 UTC) #2
scottmg
6 years, 5 months ago (2014-07-17 19:43:13 UTC) #3
Message was sent while issue was closed.
lgtm (looks like it's !chromium_code in gyp too)

Powered by Google App Engine
This is Rietveld 408576698