Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 399153003: Land Recent QUIC Changes. (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)
Modified:
6 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Cleanup and adding GetCongestionControlType. Merge internal change: 71125139 https://codereview.chromium.org/400813002/ QUIC test only change to add track the observed loss rate in SendAlgorithmSimulator. Merge internal change: 71116533 https://codereview.chromium.org/399763004/ Minor formatting changes to keep the code similar to internal tree. Merge internal change: 71059110 https://codereview.chromium.org/393283005/ Add more testing to QUIC's BbrTcpSender to verify it shares bandwidth fairly with itself. Also includes fixes to SendAlgorithmSimulator. Merge internal change: 71000950 https://codereview.chromium.org/399793002/ Will merge BbrTcpSender changes in a future CL after the approvals. Add a DLOG that indicates the peer sent us a QUIC_PUBLIC_RESET. Makes it more obvious why the connection ended when running the quic_client. Merge internal change: 70900278 https://codereview.chromium.org/399793002/ QUIC test only change to add a convenience operator for printing SendAlgorithmSimulator stats. Merge internal change: 70897829 https://codereview.chromium.org/399773003/ Adds dynamic setting of FEC group size based on the connection's current congestion window. There will be two triggers for transmitted an FEC packet, when protection is required -- max_packets_per_fec_group, and an FEC alarm that triggers an FEC packet if the FEC group has been open for long enough. This CL implements dynamically setting max_packets_per_fec_group. The FEC alarm will be written in a subsequent CL. Merge internal change: 70821636 https://codereview.chromium.org/398873003/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284205

Patch Set 1 : Merge with TOT #

Patch Set 2 : Added NET_EXPORT_PRIVATE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -93 lines) Patch
M net/quic/congestion_control/fix_rate_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/fix_rate_sender.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/congestion_control/receive_algorithm_interface.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_simulator.h View 4 chunks +21 lines, -1 line 0 comments Download
M net/quic/congestion_control/send_algorithm_simulator.cc View 10 chunks +43 lines, -25 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 3 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_connection_logger.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M net/quic/quic_packet_creator.h View 1 chunk +4 lines, -5 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 4 chunks +18 lines, -2 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M net/quic/quic_packet_generator.h View 4 chunks +8 lines, -2 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 4 chunks +33 lines, -12 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +67 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +11 lines, -4 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 4 chunks +20 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 5 chunks +29 lines, -14 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 15 chunks +46 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +14 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ramant (doing other things)
6 years, 5 months ago (2014-07-17 20:44:06 UTC) #1
Ryan Hamilton
lgtm
6 years, 5 months ago (2014-07-18 15:57:23 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 5 months ago (2014-07-18 17:00:03 UTC) #3
ramant (doing other things)
The CQ bit was unchecked by rtenneti@chromium.org
6 years, 5 months ago (2014-07-18 17:00:05 UTC) #4
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 5 months ago (2014-07-18 17:00:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/399153003/30001
6 years, 5 months ago (2014-07-18 17:02:12 UTC) #6
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 5 months ago (2014-07-18 17:59:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/399153003/50001
6 years, 5 months ago (2014-07-18 18:00:26 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 21:35:28 UTC) #9
Message was sent while issue was closed.
Change committed as 284205

Powered by Google App Engine
This is Rietveld 408576698