Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 399153002: Revert 283678 "Refactor code that defers extension background pa..." (Closed)

Created:
6 years, 5 months ago by James Cook
Modified:
6 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 283678 "Refactor code that defers extension background pa..." This broke Chrome OS valgrind bots, for example: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/27033 > Refactor code that defers extension background page loading > > src/extensions depends on chrome::NOTIFICATION_PROFILE_CREATED to support deferred loading of extension background pages when the profile isn't ready yet. This is a layering violation. > > * Remove Chrome concepts like "browser window ready" and "profile created" from ProcessManager. Introduce ProcessManagerDelegate with a general concept of deferring background page loading. > * Consolidate all the tricky Chrome-specific background page loading rules into ChromeProcessManagerDelegate. This keeps all the rules in one place. Annotate each block of special case code with the bug that inspired it. > * Extend unit test coverage for ProcessManager. > > This will make it easier to eliminate chrome::NOTIFICATION_PROFILE_DESTROYED in ProcessManager in a later CL. > > BUG=392658 > TEST=unit_tests ProcessManagerTest, browser_tests ProcessManagerBrowserTest, manual > > Review URL: https://codereview.chromium.org/381283002 TBR=jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -443 lines) Patch
M trunk/src/apps/shell/browser/shell_extensions_browser_client.h View 1 chunk +4 lines, -1 line 0 comments Download
M trunk/src/apps/shell/browser/shell_extensions_browser_client.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/chrome_extensions_browser_client.h View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/extensions/chrome_extensions_browser_client.cc View 3 chunks +26 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/extensions/chrome_notification_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/chrome_notification_observer.cc View 2 chunks +43 lines, -0 lines 0 comments Download
D trunk/src/chrome/browser/extensions/chrome_process_manager_delegate.h View 1 chunk +0 lines, -50 lines 0 comments Download
D trunk/src/chrome/browser/extensions/chrome_process_manager_delegate.cc View 1 chunk +0 lines, -143 lines 0 comments Download
M trunk/src/chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/extensions/DEPS View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/extensions/browser/extensions_browser_client.h View 2 chunks +6 lines, -4 lines 0 comments Download
M trunk/src/extensions/browser/process_manager.h View 6 chunks +9 lines, -12 lines 0 comments Download
M trunk/src/extensions/browser/process_manager.cc View 10 chunks +56 lines, -42 lines 0 comments Download
D trunk/src/extensions/browser/process_manager_delegate.h View 1 chunk +0 lines, -34 lines 0 comments Download
M trunk/src/extensions/browser/process_manager_unittest.cc View 5 chunks +1 line, -121 lines 0 comments Download
M trunk/src/extensions/browser/test_extensions_browser_client.h View 3 chunks +5 lines, -9 lines 0 comments Download
M trunk/src/extensions/browser/test_extensions_browser_client.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M trunk/src/extensions/extensions.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
James Cook
6 years, 5 months ago (2014-07-17 17:21:34 UTC) #1
James Cook
6 years, 5 months ago (2014-07-17 17:21:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r283801.

Powered by Google App Engine
This is Rietveld 408576698