Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 399143009: Add NULL check in OnPdfToEmfConverted (Closed)

Created:
6 years, 5 months ago by scottmg
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/printing/print_view_manager_base.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scottmg
6 years, 5 months ago (2014-07-18 18:15:09 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 5 months ago (2014-07-18 18:52:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/399143009/1
6 years, 5 months ago (2014-07-18 18:55:21 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 20:43:35 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 21:09:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172666)
6 years, 5 months ago (2014-07-18 21:09:14 UTC) #6
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 5 months ago (2014-07-18 21:14:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/399143009/1
6 years, 5 months ago (2014-07-18 21:16:02 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 22:28:42 UTC) #9
Message was sent while issue was closed. 
Change committed as 284225

Powered by Google App Engine
This is Rietveld 408576698