Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 399143005: Don't build x509_certificate_model_unittest.cc on Windows and Mac. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Don't build x509_certificate_model_unittest.cc on Windows and Mac. It's only implemented and used if NSS (or later OpenSSL) provide the certificate information. The check was checking against use_openssl rather than use_openssl_certs. BUG=394959 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284022

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
davidben
6 years, 5 months ago (2014-07-17 23:57:54 UTC) #1
Ryan Sleevi
lgtm
6 years, 5 months ago (2014-07-17 23:58:19 UTC) #2
davidben
On 2014/07/17 23:58:19, Ryan Sleevi wrote: > lgtm Oh, for completeness, this block does not ...
6 years, 5 months ago (2014-07-18 00:03:34 UTC) #3
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-18 00:03:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/399143005/1
6 years, 5 months ago (2014-07-18 00:07:27 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 04:50:13 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 07:12:13 UTC) #7
Message was sent while issue was closed.
Change committed as 284022

Powered by Google App Engine
This is Rietveld 408576698