Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11427)

Unified Diff: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

Issue 399143004: Open the WrenchMenu on mouseover when dragging a browser action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Win/Test Fix Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
index f94ac694a14cf9afa5bf66e21e902b40e7af22bd..daa5732a0305fb3d9c6fb2cba072f8b6e69d76ab 100644
--- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
+++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
@@ -181,21 +181,17 @@ bool BrowserActionOverflowMenuController::GetDropFormats(
views::MenuItemView* menu,
int* formats,
std::set<OSExchangeData::CustomFormat>* custom_formats) {
- custom_formats->insert(BrowserActionDragData::GetBrowserActionCustomFormat());
- return true;
+ return BrowserActionDragData::GetDropFormats(custom_formats);
}
bool BrowserActionOverflowMenuController::AreDropTypesRequired(
views::MenuItemView* menu) {
- return true;
+ return BrowserActionDragData::AreDropTypesRequired();
}
bool BrowserActionOverflowMenuController::CanDrop(
views::MenuItemView* menu, const OSExchangeData& data) {
- BrowserActionDragData drop_data;
- if (!drop_data.Read(data))
- return false;
- return drop_data.IsFromProfile(owner_->profile());
+ return BrowserActionDragData::CanDrop(data, owner_->profile());
}
int BrowserActionOverflowMenuController::GetDropOperation(
« no previous file with comments | « chrome/browser/ui/views/extensions/browser_action_drag_data.cc ('k') | chrome/browser/ui/views/menu_test_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698