Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: chrome/browser/ui/views/extensions/browser_action_drag_data.h

Issue 399143004: Open the WrenchMenu on mouseover when dragging a browser action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/browser_action_drag_data.h
diff --git a/chrome/browser/ui/views/extensions/browser_action_drag_data.h b/chrome/browser/ui/views/extensions/browser_action_drag_data.h
index 563a04e4024fe3ea03199d5c7d8bcda793acb12f..b856ebfc47d7f725b106f0a9729e8cb171b638d2 100644
--- a/chrome/browser/ui/views/extensions/browser_action_drag_data.h
+++ b/chrome/browser/ui/views/extensions/browser_action_drag_data.h
@@ -21,12 +21,20 @@ class BrowserActionDragData {
BrowserActionDragData();
BrowserActionDragData(const std::string& id, int index);
+ // These mirror the views::View and views::MenuDelegate methods for dropping,
+ // and return the appropriate results for being able to drop an extension's
+ // BrowserAction view.
+ static bool GetDropFormats(
+ int* formats, std::set<ui::OSExchangeData::CustomFormat>* custom_formats);
+ static bool AreDropTypesRequired();
+ static bool CanDrop(const ui::OSExchangeData& data, const Profile* profile);
+
const std::string& id() const { return id_; }
size_t index() const { return index_; }
// Returns true if this data is from the specified profile.
- bool IsFromProfile(Profile* profile) const;
+ bool IsFromProfile(const Profile* profile) const;
#if defined(TOOLKIT_VIEWS)
void Write(Profile* profile, ui::OSExchangeData* data) const;
@@ -51,9 +59,6 @@ class BrowserActionDragData {
// The index of the view being dragged.
size_t index_;
- // The MIME type for the clipboard format for BrowserActionDragData.
- static const char* kClipboardFormatString;
-
DISALLOW_COPY_AND_ASSIGN(BrowserActionDragData);
};

Powered by Google App Engine
This is Rietveld 408576698