Open the WrenchMenu on mouseover when dragging a browser action

ui/views/controls/menu/menu_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_controller.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/i18n/rtl.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
@@ skipping 1560 matching lines @@
                     this, &MenuController::CommitPendingSelection);
 }
 
 void MenuController::StopShowTimer() {
   show_timer_.Stop();
 }
 
 void MenuController::StartCancelAllTimer() {
   cancel_all_timer_.Start(FROM_HERE,
                           TimeDelta::FromMilliseconds(kCloseOnExitTime),
-                          this, &MenuController::CancelAll);
+                          this, &MenuController::CancelAllForDrag);
 }
 
 void MenuController::StopCancelAllTimer() {
   cancel_all_timer_.Stop();
 }
 
+void MenuController::CancelAllForDrag() {
+  // It's possible that a child View will be in the middle of a drag-and-drop
+  // operation that we didn't get events for (since we only get updated for
+  // MenuItemViews). If so, just restart the cancel timer.
+  if (state_.item &&
+      state_.item->GetDelegate() &&
+      state_.item->GetDelegate()->InNestedDrag())

[sky, 2014/07/18 19:36:54]

This isn't state that's going to change. So it should be passed in rather than
another delegate call.

[Devlin, 2014/07/18 21:38:31]

Sorry, not sure I follow.  Passed in to where?

[sky, 2014/07/18 22:45:39]

Into MenuRunner when you Run the menu. Basically I'm saying add another param to
MenuRunner::Run().

[Devlin, 2014/07/21 20:00:56]

Done.

+    StartCancelAllTimer();
+  else
+    CancelAll();
+}
+
 gfx::Rect MenuController::CalculateMenuBounds(MenuItemView* item,
                                               bool prefer_leading,
                                               bool* is_leading) {
   DCHECK(item);
 
   SubmenuView* submenu = item->GetSubmenu();
   DCHECK(submenu);
 
   gfx::Size pref = submenu->GetScrollViewContainer()->GetPreferredSize();
 
@@ skipping 701 matching lines @@
   }
 }
 
 gfx::Screen* MenuController::GetScreen() {
   Widget* root = owner_ ? owner_->GetTopLevelWidget() : NULL;
   return root ? gfx::Screen::GetScreenFor(root->GetNativeView())
               : gfx::Screen::GetNativeScreen();
 }
 
 }  // namespace views