Open the WrenchMenu on mouseover when dragging a browser action

chrome/browser/ui/views/extensions/browser_action_drag_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/browser_action_drag_data.h"
 
 #include "base/logging.h"
 #include "base/pickle.h"
 #include "base/strings/string_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "ui/base/clipboard/clipboard.h"
 
-const char* BrowserActionDragData::kClipboardFormatString =
-    "chromium/x-browser-actions";
+namespace {
+
+// The MIME type for the clipboard format for BrowserActionDragData.
+const char* kClipboardFormatString = "chromium/x-browser-actions";

[dcheng, 2014/07/17 19:58:02]

Minor nit: const char kClipboardFormatString[]

[Devlin, 2014/07/17 20:43:34]

Sure, done.

+
+}
 
 BrowserActionDragData::BrowserActionDragData()
     : profile_(NULL), index_(static_cast<size_t>(-1)) {
 }
 
 BrowserActionDragData::BrowserActionDragData(
     const std::string& id, int index)
     : profile_(NULL), id_(id), index_(index) {
 }
 
-bool BrowserActionDragData::IsFromProfile(Profile* profile) const {
+bool BrowserActionDragData::GetDropFormats(
+    int* formats, std::set<ui::OSExchangeData::CustomFormat>* custom_formats) {

[dcheng, 2014/07/17 19:58:03]

Given that |formats| isn't used here at all, probably no need to pass it atm.

[Devlin, 2014/07/17 20:43:34]

Mmkay.  Originally I had it just so it shadowed the View method better, but I
don't feel strongly either way.

+  custom_formats->insert(GetBrowserActionCustomFormat());
+  return true;
+}
+
+bool BrowserActionDragData::AreDropTypesRequired() {
+  return true;
+}
+
+bool BrowserActionDragData::CanDrop(const ui::OSExchangeData& data,
+                                    const Profile* profile) {
+  BrowserActionDragData drop_data;
+  return drop_data.Read(data) && drop_data.IsFromProfile(profile);
+}
+
+bool BrowserActionDragData::IsFromProfile(const Profile* profile) const {
   return profile_ == profile;
 }
 
 #if defined(TOOLKIT_VIEWS)
 void BrowserActionDragData::Write(
     Profile* profile, ui::OSExchangeData* data) const {
   DCHECK(data);
   Pickle data_pickle;
   WriteToPickle(profile, &data_pickle);
   data->SetPickledData(GetBrowserActionCustomFormat(), data_pickle);
@@ skipping 43 matching lines @@
   if (!pickle->ReadString(&data_iterator, &id_))
     return false;
 
   uint64 index;
   if (!pickle->ReadUInt64(&data_iterator, &index))
     return false;
   index_ = static_cast<size_t>(index);
 
   return true;
 }