Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
399133008:
MacViews: Remove const from NativeWidgetMac::OnRootViewLayout to match other NativeWidget* (Closed)
|
Created:
6 years, 5 months ago by tapted Modified:
6 years, 5 months ago CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org, pkotwicz, mac-views-reviews_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Project:
chromium Visibility:
Public. |
DescriptionMacViews: Remove const from NativeWidgetMac::OnRootViewLayout to match other NativeWidget*
The `const` was removed in http://crrev.com/283945 for the other
native widget types.
BUG=366007, 382301
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284384
Patch Set 1 #Patch Set 2 : Fix conflict with r284026 #
Messages
Total messages: 25 (0 generated)
sadrul for OWNERS cc pkotwicz fyi (r283945 only just landed so not rushing)
lgtm
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/399133008/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/399133008/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/399133008/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/399133008/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/399133008/20001
Message was sent while issue was closed.
Change committed as 284384 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
