chrome/test/chromedriver/run_buildbot_steps.py - Issue 399133006: [chromedriver] Catch URLError during buildbot wait_for_snapshot step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/run_buildbot_steps.py

Issue 399133006: [chromedriver] Catch URLError during buildbot wait_for_snapshot step. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/run_buildbot_steps.py

diff --git a/chrome/test/chromedriver/run_buildbot_steps.py b/chrome/test/chromedriver/run_buildbot_steps.py

index 276b0c3982ed213a2ff3bce6f9a68585a02e7ab4..dd1a3714713285524bc72bb0dba642bdc2ae9846 100755

--- a/chrome/test/chromedriver/run_buildbot_steps.py

+++ b/chrome/test/chromedriver/run_buildbot_steps.py

@@ -390,6 +390,8 @@ def _GetSVNRevisionFromGitHash(snapshot_hashcode):

response = urllib2.urlopen(json_url)

except urllib2.HTTPError as error:

util.PrintAndFlush('HTTP Error %d' % error.getcode())

+ except urllib2.URLError as error:

+ util.PrintAndFlush('URL Error %s' % error.message)

return None

data = json.loads(response.read()[4:])

if 'message' in data:

« no previous file with comments | « no previous file | no next file » | no next file with comments »