Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 39913002: Experimental scanner: pass -b to re2c. (Closed)

Created:
7 years, 2 months ago by marja
Modified:
7 years, 2 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Experimental scanner: pass -b to re2c. It seems to generate a bit faster scanner. From re2c doc: -b: Implies -s. Use bit vectors as well in the attempt to coax better code out of the compiler. Most useful for specifications with more than a few keywords (e.g. for most programming languages). -s: Generate nested ifs for some switches. Many compilers need this assist to generate better code. BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/lexer/lexer.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dcarney
lgtm
7 years, 2 months ago (2013-10-24 10:32:52 UTC) #1
marja
7 years, 2 months ago (2013-10-24 11:01:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r17371 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698