Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 399115: Merge 32413 - Tweaks and fixes for NTP extension promo.... (Closed)

Created:
11 years, 1 month ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 32413 - Tweaks and fixes for NTP extension promo. Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing. BUG=27814, 25258, 27815 TEST= see various bugs. Review URL: http://codereview.chromium.org/385135 TBR=mirandac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -27 lines) Patch
M chrome/browser/browser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_theme_source.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 3 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/resources/new_new_tab.css View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/resources/new_new_tab.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/new_new_tab.js View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Miranda Callahan
11 years, 1 month ago (2009-11-19 16:04:15 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698