Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1707)

Unified Diff: chrome/browser/gtk/bookmark_manager_browsertest.cc

Issue 399104: BookmarkManagerTest now passes without this hack. (Closed)
Patch Set: " Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/bookmark_manager_browsertest.cc
diff --git a/chrome/browser/gtk/bookmark_manager_browsertest.cc b/chrome/browser/gtk/bookmark_manager_browsertest.cc
index 1d8b8b00167ba5a4181ea8857957db5775480851..6cb32894e76f401a98a6a36e296039bd868dd721 100644
--- a/chrome/browser/gtk/bookmark_manager_browsertest.cc
+++ b/chrome/browser/gtk/bookmark_manager_browsertest.cc
@@ -81,13 +81,4 @@ IN_PROC_BROWSER_TEST_F(BookmarkManagerTest, Crash) {
manager_->SelectInTree(model_->GetBookmarkBarNode(), true);
CleanUp();
-#if defined(TOOLKIT_VIEWS)
- // The test fails on toolkit_views build without the following
- // cleanup code. This is because the bookmark bar view refuses to
- // be destroyed by a bookmark model when the BrowserProcessImpl
- // destroys the bookmark bar model.
- // TODO(oshima): http://crbug/28046.
- browser()->window()->Close();
- MessageLoopForUI::current()->RunAllPending();
-#endif
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698