Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 399058: Merge 32166 - A quick fix for Issue 3798.... (Closed)

Created:
11 years, 1 month ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
Hironori Bono
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 32166 - A quick fix for Issue 3798. Some Chinese IMEs insert whitespace characters (U+3000) instead of input characters while they are composing text. So, trimming these whitespace characters (at the beginning of an omnibox) prevents from inputting text on these IMEs. As a quick fix, this change prevent our AutocompleteEditViewWin::OnImeComposition() from starting autocomplete when an omnibox starts with whitespace characters. BUG=3798 TEST=Type "google.com" on Omnibox, type "Tab" to start tabtosearch, type 'nihao' on Microsoft New Phonetic IME, and see we can see Chinese characters in the omnibox. Review URL: http://codereview.chromium.org/391070 TBR=hbono@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Hironori Bono
11 years, 1 month ago (2009-11-18 03:09:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698