Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 399044: Merge r3285, r3313, and r3318 to branches/1.3. (Closed)

Created:
11 years, 1 month ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merge r3285, r3313, and r3318 to branches/1.3. This includes fixes to avoid bogus FatalProcessOutOfMemory issues (3285), 13.4% compiled code size reduction (3313), and a critical fix to avoid potentially orphaning global handles (3318).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -36 lines) Patch
M src/global-handles.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/heap.cc View 5 chunks +11 lines, -6 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +18 lines, -2 lines 0 comments Download
M src/ia32/register-allocator-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/virtual-frame-ia32.cc View 6 chunks +14 lines, -19 lines 0 comments Download
M src/runtime.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kasper Lund
After talking to Anthony, the plan is to change Chromium to pull V8 from branches/1.3 ...
11 years, 1 month ago (2009-11-17 21:28:25 UTC) #1
fschneider
Changes in ia32/ LGTM.
11 years, 1 month ago (2009-11-17 21:36:42 UTC) #2
fschneider
LGTM.
11 years, 1 month ago (2009-11-17 21:40:27 UTC) #3
Christian Plesner Hansen
11 years, 1 month ago (2009-11-18 04:45:03 UTC) #4
As you may have discovered something in this change is broken.  Also, I would
recommend against against pulling directly from 1.3 since that means we can't
test our changes on the dev channel before pushing to 1.3.

Powered by Google App Engine
This is Rietveld 408576698