Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1814)

Unified Diff: Source/devtools/front_end/timeline/TimelineModelImpl.js

Issue 399043002: DevTools: switch Timeline frontend into buffered mode and remove the corresponding experiment. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: minor changes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineModelImpl.js
diff --git a/Source/devtools/front_end/timeline/TimelineModelImpl.js b/Source/devtools/front_end/timeline/TimelineModelImpl.js
index d44ae4a323b915d1dfd2decc791b936adcf42599..36b03055f9ea8a783eee2c588e94549df07421e9 100644
--- a/Source/devtools/front_end/timeline/TimelineModelImpl.js
+++ b/Source/devtools/front_end/timeline/TimelineModelImpl.js
@@ -49,13 +49,13 @@ WebInspector.TimelineModelImpl.prototype = {
WebInspector.TimelineModel.RecordType.DrawFrame,
WebInspector.TimelineModel.RecordType.RequestMainThreadFrame,
WebInspector.TimelineModel.RecordType.ActivateLayerTree ];
- this._timelineManager.start(maxStackFrames, WebInspector.experimentsSettings.timelineNoLiveUpdate.isEnabled(), liveEvents.join(","), captureMemory, includeGPUEvents, this._fireRecordingStarted.bind(this));
+ this._timelineManager.start(maxStackFrames, liveEvents.join(","), captureMemory, includeGPUEvents, this._fireRecordingStarted.bind(this));
},
stopRecording: function()
{
if (!this._clientInitiatedRecording) {
- this._timelineManager.start(undefined, undefined, undefined, undefined, undefined, stopTimeline.bind(this));
+ this._timelineManager.start(undefined, undefined, undefined, undefined, stopTimeline.bind(this));
return;
}
@@ -86,8 +86,7 @@ WebInspector.TimelineModelImpl.prototype = {
*/
_onRecordAdded: function(event)
{
- if (this._collectionEnabled)
yurys 2014/07/17 10:42:24 Without this check we will display events if timel
- this._addRecord(/** @type {!TimelineAgent.TimelineEvent} */(event.data));
+ this._addRecord(/** @type {!TimelineAgent.TimelineEvent} */(event.data));
},
/**
@@ -106,9 +105,8 @@ WebInspector.TimelineModelImpl.prototype = {
*/
_onStopped: function(event)
{
- // If we were buffering events, discard those that got through, the real ones are coming!
- if (WebInspector.experimentsSettings.timelineNoLiveUpdate.isEnabled())
- this.reset();
+ // We were buffering events, discard those that got through, the real ones are coming!
+ this.reset();
if (event.data) {
// Stopped from console.
this._fireRecordingStopped(null, null);
@@ -125,7 +123,6 @@ WebInspector.TimelineModelImpl.prototype = {
_fireRecordingStarted: function()
{
- this._collectionEnabled = true;
this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordingStarted);
},
@@ -135,7 +132,6 @@ WebInspector.TimelineModelImpl.prototype = {
*/
_fireRecordingStopped: function(error, cpuProfile)
{
- this._collectionEnabled = false;
if (cpuProfile)
WebInspector.TimelineJSProfileProcessor.mergeJSProfileIntoTimeline(this, cpuProfile);
this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordingStopped);

Powered by Google App Engine
This is Rietveld 408576698