Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: LayoutTests/http/tests/inspector/timeline-xhr-response-type-blob-event.html

Issue 399043002: DevTools: switch Timeline frontend into buffered mode and remove the corresponding experiment. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: timeline-websocket-event rebaselined Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/inspector/timeline-xhr-response-type-blob-event.html
diff --git a/LayoutTests/http/tests/inspector/timeline-xhr-response-type-blob-event.html b/LayoutTests/http/tests/inspector/timeline-xhr-response-type-blob-event.html
index 196bf70dda4189e1afde88e4883fac59f5ada476..e0732d1d24003ce57cc37957e7a5afded9af4c1b 100644
--- a/LayoutTests/http/tests/inspector/timeline-xhr-response-type-blob-event.html
+++ b/LayoutTests/http/tests/inspector/timeline-xhr-response-type-blob-event.html
@@ -5,13 +5,19 @@
<script src="network-test.js"></script>
<script>
-function performActions()
+function performActions(callback)
{
var xhr = new XMLHttpRequest();
xhr.responseType = "blob";
xhr.open("GET", "network/resources/resource.php", true);
- xhr.onload = function () { }; // This is necessary for XHRLoad event.
- xhr.onreadystatechange = function () { }; // This is necessary for XHRReadyStateChange event.
+ xhr.onload = function() { }; // This is necessary for XHRLoad event.
+ // assigning callback to onload doesn't work here due to exception in responseXML handling for blob response type.
+ xhr.onreadystatechange = done;
+ function done()
+ {
+ if (xhr.readyState === 4)
+ callback();
+ }
xhr.send(null);
}
@@ -20,11 +26,7 @@ function test()
InspectorTest.resetInspectorResourcesData(step1);
function step1()
{
- InspectorTest.startTimeline(function() {
- InspectorTest.evaluateInPage("performActions()");
- });
-
- InspectorTest.waitForRecordType("XHRLoad", finish);
+ InspectorTest.invokeAsyncWithTimeline("performActions", finish);
function finish()
{

Powered by Google App Engine
This is Rietveld 408576698