Source/core/inspector/InspectorTimelineAgent.cpp - Issue 399043002: DevTools: switch Timeline frontend into buffered mode and remove the corresponding experiment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorTimelineAgent.cpp

Issue 399043002: DevTools: switch Timeline frontend into buffered mode and remove the corresponding experiment. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: comments addressed Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorTimelineAgent.cpp

diff --git a/Source/core/inspector/InspectorTimelineAgent.cpp b/Source/core/inspector/InspectorTimelineAgent.cpp

index 8ae63728d17c1f358a082b62995193c74a6a4338..48472801e26a051e0612f4d9e11afd9ad68f748f 100644

--- a/Source/core/inspector/InspectorTimelineAgent.cpp

+++ b/Source/core/inspector/InspectorTimelineAgent.cpp

@@ -827,6 +827,9 @@ void InspectorTimelineAgent::consoleTimeline(ExecutionContext* context, const St

mainFrame()->console().addMessage(JSMessageSource, DebugMessageLevel, message, String(), 0, 0, nullptr, scriptState);

m_consoleTimelines.append(title);

if (!isStarted()) {

+ m_state->setBoolean(TimelineAgentState::bufferEvents, true);

yurys 2014/07/29 07:19:21 Please mention this change in the description of t

+ m_bufferedEvents = TypeBuilder::Array<TimelineEvent>::create();

innerStart();

bool fromConsole = true;

m_frontend->started(&fromConsole);

« no previous file with comments | « LayoutTests/inspector/timeline/timeline-window-filter.html ('k') | Source/devtools/front_end/common/Settings.js » ('j') | no next file with comments »