DevTools: switch Timeline frontend into buffered mode and remove the corresponding experiment.

Source/devtools/front_end/timeline/TimelineModelImpl.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.TimelineModel}
  * @implements {WebInspector.TargetManager.Observer}
  */
 WebInspector.TimelineModelImpl = function()
@@ skipping 42 matching lines @@
         this._currentTarget = WebInspector.context.flavor(WebInspector.Target);
         console.assert(this._currentTarget);
 
         this._clientInitiatedRecording = true;
         var maxStackFrames = captureStacks ? 30 : 0;
         var includeGPUEvents = WebInspector.experimentsSettings.gpuTimeline.isEnabled();
         var liveEvents = [ WebInspector.TimelineModel.RecordType.BeginFrame,
                            WebInspector.TimelineModel.RecordType.DrawFrame,
                            WebInspector.TimelineModel.RecordType.RequestMainThreadFrame,
                            WebInspector.TimelineModel.RecordType.ActivateLayerTree ];
-        this._currentTarget.timelineManager.start(maxStackFrames, WebInspector.experimentsSettings.timelineNoLiveUpdate.isEnabled(), liveEvents.join(","), captureMemory, includeGPUEvents, this._fireRecordingStarted.bind(this));
+        this._currentTarget.timelineManager.start(maxStackFrames, liveEvents.join(","), captureMemory, includeGPUEvents, this._fireRecordingStarted.bind(this));
     },
 
     stopRecording: function()
     {
         if (!this._currentTarget)
             return;
 
         if (!this._clientInitiatedRecording) {
-            this._currentTarget.timelineManager.start(undefined, undefined, undefined, undefined, undefined, stopTimeline.bind(this));
+            this._currentTarget.timelineManager.start(undefined, undefined, undefined, undefined, stopTimeline.bind(this));
             return;
         }
 
         /**
          * Console started this one and we are just sniffing it. Initiate recording so that we
          * could stop it.
          * @this {WebInspector.TimelineModelImpl}
          */
         function stopTimeline()
         {
@@ skipping 11 matching lines @@
     {
         return this._records;
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onRecordAdded: function(event)
     {
         var timelineManager = /** @type {!WebInspector.TimelineManager} */ (event.target);
-        if (this._collectionEnabled && timelineManager.target() === this._currentTarget)
+        if (timelineManager.target() === this._currentTarget)
             this._addRecord(/** @type {!TimelineAgent.TimelineEvent} */(event.data));
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onStarted: function(event)
     {
-        if (!event.data || this._collectionEnabled)

[yurys, 2014/07/24 16:58:37]

Revert this. You can reset this flag on RecordProcessed event.

[loislo, 2014/07/28 14:00:06]

Done.

+        if (!event.data)
             return;
         // Started from console.
         var timelineManager = /** @type {!WebInspector.TimelineManager} */ (event.target);
         if (this._currentTarget !== timelineManager.target()) {
             this.reset();
             this._currentTarget = timelineManager.target();
         }
         this._fireRecordingStarted();
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onStopped: function(event)
     {
         var timelineManager = /** @type {!WebInspector.TimelineManager} */ (event.target);
         if (timelineManager.target() !== this._currentTarget)
             return;
-        // If we were buffering events, discard those that got through, the real ones are coming!
-        if (WebInspector.experimentsSettings.timelineNoLiveUpdate.isEnabled()) {
-            this.reset();
-            this._currentTarget = timelineManager.target();
-        }
+        // We were buffering events, discard those that got through, the real ones are coming!
+        this.reset();
+        this._currentTarget = timelineManager.target();
         if (event.data) {
             // Stopped from console.
             this._fireRecordingStopped(null, null);
         }
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onProgress: function(event)
     {
         var timelineManager = /** @type {!WebInspector.TimelineManager} */ (event.target);
         if (timelineManager.target() === this._currentTarget)
             this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordingProgress, event.data);
     },
 
     _fireRecordingStarted: function()
     {
-        this._collectionEnabled = true;
         this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordingStarted);
     },
 
     /**
      * @param {?Protocol.Error} error
      * @param {?ProfilerAgent.CPUProfile} cpuProfile
      */
     _fireRecordingStopped: function(error, cpuProfile)
     {
-        this._collectionEnabled = false;
         if (cpuProfile)
             WebInspector.TimelineJSProfileProcessor.mergeJSProfileIntoTimeline(this, cpuProfile);
         this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordingStopped);
     },
 
     /**
      * @param {!TimelineAgent.TimelineEvent} payload
      */
     _addRecord: function(payload)
     {
@@ skipping 551 matching lines @@
                 break;
             length += itemLength;
             data.push(item);
             ++this._recordIndex;
         }
         if (this._recordIndex === this._payloads.length)
             data.push(data.pop() + "]");
         stream.write(data.join(separator), this._writeNextChunk.bind(this));
     }
 }