Fix a crash when activating a select element inside a page action

Fix a crash when activating a select element inside a page 
action popup.

With this change, select elements still don't work correctly 
with page actions: when you try to use them, the page action 
popup disappears. However, at least now, it doesn't crash.

BUG=27576
TEST=Install extension in related bug. Navigate to any site 
and click page action. Browser should not crash.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32277

[Erik does not do reviews, 2009-11-17 16:32:17]

http://codereview.chromium.org/399032/diff/1001/9
File chrome/browser/views/location_bar_view.cc (right):

http://codereview.chromium.org/399032/diff/1001/9#newcode1344
Line 1344: popup_ = ExtensionPopup::Show(page_action_->popup_url(), browser,
rect,
Given the dismiss via a timer, you need to check for popup_ and cancel the timer
if it's there.

[Aaron Boodman, 2009-11-18 00:50:40]

Good point, fixed that, and moved the coordinate calculation down closer to
where it is used for style, and also to be more like the browser action
implementation.

[Erik does not do reviews, 2009-11-18 00:55:18]

LGTM

http://codereview.chromium.org/399032/diff/3002/5002
File chrome/browser/views/location_bar_view.cc (right):

http://codereview.chromium.org/399032/diff/3002/5002#newcode1339
Line 1339: HidePopup();
to avoid flicker, you could also check if the current popup is the same as the
new one, but that could be a TODO for now.