Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 399031: A fix for Issue 18994.... (Closed)

Created:
11 years, 1 month ago by Hironori Bono
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

A fix for Issue 18994. This change retrieves the number of slots available for custom JumpList items to calculate the items for "Most Visited" items and for "Recently Closed" items. As written in the MSDN doc, Windows 7 changes the number of JumpList slots at run time and it truncates the items from the bottom (i.e. "Recently Closed" items) if we add more items than available ones. To fix this issue, this change assigned 60% of available JumpList slots to the "Most Visited" category and 40% to the "Recently Closed" category, respectively. (If there are not so many "Recently Closed" Items, this change increases the number of "Most Visited" items.) Also, this change sets the AppID since <http://codereview.chromium.org/385120>; changes it. BUG=18994 TEST=Open a JumpList and see there are two or more "Recently Closed" items in it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32308

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M chrome/browser/jumplist.cc View 1 7 chunks +29 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hironori Bono
11 years, 1 month ago (2009-11-17 07:17:51 UTC) #1
Ben Goodger (Google)
11 years, 1 month ago (2009-11-17 18:35:05 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698