Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 399030: Add an option to tree_view for whether to show lines from the root node... (Closed)

Created:
11 years, 1 month ago by ian fette
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Add an option to tree_view for whether to show lines from the root node to children nodes (sets TVS_LINESATROOT). Set this to false by default (maintaining existing behaviour by default), except for cookies_view where we set it to true. BUG=27657 TEST=open cookies dialog, make sure the origins have a + box next to them, and that expanding these also expands the cookies folder beneath them.

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M chrome/browser/views/options/cookies_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M views/controls/tree/tree_view.h View 1 3 chunks +25 lines, -2 lines 0 comments Download
M views/controls/tree/tree_view.cc View 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
LGTM with the following changes. http://codereview.chromium.org/399030/diff/1/2 File views/controls/tree/tree_view.h (right): http://codereview.chromium.org/399030/diff/1/2#newcode63 Line 63: void SetAutoExpandChildren(bool auto_expand_children) ...
11 years, 1 month ago (2009-11-17 19:16:01 UTC) #1
ian fette
Code review tool is down right now, otherwise I would enter this there... will copy ...
11 years, 1 month ago (2009-11-17 19:51:57 UTC) #2
ian fette
Thanks for the review. Addressed your concerns, and submitting. http://codereview.chromium.org/399030/diff/1/2 File views/controls/tree/tree_view.h (right): http://codereview.chromium.org/399030/diff/1/2#newcode63 Line ...
11 years, 1 month ago (2009-11-17 23:01:58 UTC) #3
ian fette
11 years, 1 month ago (2009-11-18 17:47:44 UTC) #4
gcl failed to close. Committed as revision 32334.

Powered by Google App Engine
This is Rietveld 408576698