Add an option to tree_view for whether to show lines from the root node...

Add an option to tree_view for whether to show lines from the root node
to children nodes (sets TVS_LINESATROOT). Set this to false by default
(maintaining existing behaviour by default), except for cookies_view where
we set it to true.

BUG=27657
TEST=open cookies dialog, make sure the origins have a + box next to them,
and that expanding these also expands the cookies folder beneath them.

[sky, 2009-11-17 19:16:01]

LGTM with the following changes.

http://codereview.chromium.org/399030/diff/1/2
File views/controls/tree/tree_view.h (right):

http://codereview.chromium.org/399030/diff/1/2#newcode63
Line 63: void SetAutoExpandChildren(bool auto_expand_children) {
set_auto_expand_children, and make sure you mention this only happens the first
time the node is expanded.

http://codereview.chromium.org/399030/diff/1/2#newcode73
Line 73: void SetLinesAtRoot(bool lines_at_root) { lines_at_root_ =
lines_at_root; }
set_lines_at_root. Also, doesn't this only matter if the root is visible? If so,
that should be clear.

[ian fette, 2009-11-17 19:51:57]

Code review tool is down right now, otherwise I would enter this there...
will copy these comments in when it comes back up.

2009/11/17 <sky@chromium.org>

> LGTM with the following changes.
>
>
> http://codereview.chromium.org/399030/diff/1/2
> File views/controls/tree/tree_view.h (right):
>
> http://codereview.chromium.org/399030/diff/1/2#newcode63
> Line 63: void SetAutoExpandChildren(bool auto_expand_children) {
> set_auto_expand_children, and make sure you mention this only happens
> the first time the node is expanded.
>
>
Fine with the comment, re the style, there's (right between the
two) SetEditable -- so I was trying to match this style. Still prefer to
change to set_auto_expand_children (and not match SetEditable?)


> http://codereview.chromium.org/399030/diff/1/2#newcode73
> Line 73: void SetLinesAtRoot(bool lines_at_root) { lines_at_root_ =
> lines_at_root; }
> set_lines_at_root. Also, doesn't this only matter if the root is
> visible? If so, that should be clear.
>

No, if the root is not visible, all the children of the root basically act
like roots in the native control.


>
> http://codereview.chromium.org/399030
>

[ian fette, 2009-11-17 23:01:58]

Thanks for the review. Addressed your concerns, and submitting.

http://codereview.chromium.org/399030/diff/1/2
File views/controls/tree/tree_view.h (right):

http://codereview.chromium.org/399030/diff/1/2#newcode63
Line 63: void SetAutoExpandChildren(bool auto_expand_children) {
On 2009/11/17 19:16:01, sky wrote:
> set_auto_expand_children, and make sure you mention this only happens the
first
> time the node is expanded.

Done.

http://codereview.chromium.org/399030/diff/1/2#newcode73
Line 73: void SetLinesAtRoot(bool lines_at_root) { lines_at_root_ =
lines_at_root; }
On 2009/11/17 19:16:01, sky wrote:
> set_lines_at_root.

done

> Also, doesn't this only matter if the root is visible? If so,
> that should be clear.

No, this takes effect even if the root as not visible, as in that case the
children of the root act as roots in the native control. Added a comment to that
effect.

[ian fette, 2009-11-18 17:47:44]

gcl failed to close. Committed as revision 32334.