Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 399003002: Parse full name set in chrome://settings/autofill (Closed)

Created:
6 years, 5 months ago by Evan Stade
Modified:
6 years, 5 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, dbeam+watch-options_chromium.org, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Parse full name set in chrome://settings/autofill BUG=394273 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284635

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : stop breaking things #

Total comments: 4

Patch Set 4 : review nits #

Patch Set 5 : satisfy msvc? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -29 lines) Patch
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 2 3 4 chunks +25 lines, -15 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 2 3 4 3 chunks +59 lines, -14 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_unittest.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Evan Stade
6 years, 5 months ago (2014-07-17 03:16:36 UTC) #1
Ilya Sherman
LGTM % nits. Thanks. https://codereview.chromium.org/399003002/diff/40001/chrome/browser/ui/webui/options/autofill_options_handler.cc File chrome/browser/ui/webui/options/autofill_options_handler.cc (right): https://codereview.chromium.org/399003002/diff/40001/chrome/browser/ui/webui/options/autofill_options_handler.cc#newcode204 chrome/browser/ui/webui/options/autofill_options_handler.cc:204: void ListValueToStringVector(const base::ListValue& list, nit: ...
6 years, 5 months ago (2014-07-17 18:50:56 UTC) #2
Evan Stade
https://codereview.chromium.org/399003002/diff/40001/chrome/browser/ui/webui/options/autofill_options_handler.cc File chrome/browser/ui/webui/options/autofill_options_handler.cc (right): https://codereview.chromium.org/399003002/diff/40001/chrome/browser/ui/webui/options/autofill_options_handler.cc#newcode204 chrome/browser/ui/webui/options/autofill_options_handler.cc:204: void ListValueToStringVector(const base::ListValue& list, On 2014/07/17 18:50:56, Ilya Sherman ...
6 years, 5 months ago (2014-07-22 01:50:53 UTC) #3
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-22 01:50:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/399003002/60001
6 years, 5 months ago (2014-07-22 01:51:51 UTC) #5
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-22 01:54:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/399003002/80001
6 years, 5 months ago (2014-07-22 01:54:35 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 06:11:29 UTC) #8
Message was sent while issue was closed. 
Change committed as 284635

Powered by Google App Engine
This is Rietveld 408576698