Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 398943003: NaCl SDK: Demonstrate use of pp::View::GetDeviceScale for 3D (Closed)

Created:
6 years, 5 months ago by Josh Horwich
Modified:
6 years, 5 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Project:
chromium
Visibility:
Public.

Description

NaCl SDK: Demonstrate use of pp::View::GetDeviceScale for 3D Demonstrate in the NaCl SDK API demo for pp::Graphics3D how to use full device resolution on HiDPI displays. For Graphics3D it is simply a matter of sizing the texture in device pixels, by multiplying the width/height by view.GetDeviceScale(). BUG=196253 TEST=Build NaCl SDK, run with --force-device-scale-factor=2 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283952

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Josh Horwich
PTAL
6 years, 5 months ago (2014-07-16 23:43:30 UTC) #1
binji
lgtm https://codereview.chromium.org/398943003/diff/1/native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc File native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc (right): https://codereview.chromium.org/398943003/diff/1/native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc#newcode250 native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc:250: int32_t new_width = view.GetRect().width() * view.GetDeviceScale(); maybe a ...
6 years, 5 months ago (2014-07-17 00:05:36 UTC) #2
Josh Horwich
https://codereview.chromium.org/398943003/diff/1/native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc File native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc (right): https://codereview.chromium.org/398943003/diff/1/native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc#newcode250 native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc:250: int32_t new_width = view.GetRect().width() * view.GetDeviceScale(); On 2014/07/17 00:05:36, ...
6 years, 5 months ago (2014-07-17 00:46:13 UTC) #3
binji
great, thanks!
6 years, 5 months ago (2014-07-17 16:19:00 UTC) #4
Josh Horwich
The CQ bit was checked by jhorwich@chromium.org
6 years, 5 months ago (2014-07-17 20:25:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhorwich@chromium.org/398943003/20001
6 years, 5 months ago (2014-07-17 20:28:17 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 00:53:12 UTC) #7
Message was sent while issue was closed.
Change committed as 283952

Powered by Google App Engine
This is Rietveld 408576698