Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 398933003: Catch up to the namespace rename from WebCore to blink in dmprof. (Closed)

Created:
6 years, 5 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
6 years, 5 months ago
Reviewers:
hajimehoshi, JungJik
CC:
chromium-reviews, dmikurube+memory_chromium.org
Project:
chromium
Visibility:
Public.

Description

Catch up to the namespace rename from WebCore to blink in dmprof. BUG=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283738

Patch Set 1 #

Patch Set 2 : add sorters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -193 lines) Patch
M tools/deep_memory_profiler/README.policy View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/deep_memory_profiler/policy.android.renderer.json View 4 chunks +41 lines, -41 lines 0 comments Download
M tools/deep_memory_profiler/policy.android.webview.json View 4 chunks +40 lines, -40 lines 0 comments Download
M tools/deep_memory_profiler/policy.l1.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/deep_memory_profiler/policy.l2.json View 4 chunks +42 lines, -42 lines 0 comments Download
M tools/deep_memory_profiler/policy.linux.browser.json View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/deep_memory_profiler/policy.t0.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/deep_memory_profiler/sorter.malloc-component.json View 1 4 chunks +40 lines, -40 lines 0 comments Download
M tools/deep_memory_profiler/sorter.malloc-type.json View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/deep_memory_profiler/sorters/malloc.WebCore.json View 1 1 chunk +19 lines, -19 lines 0 comments Download
M tools/deep_memory_profiler/sorters/malloc.renderer-module.json View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/deep_memory_profiler/sorters/malloc.type.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
Dai Mikurube (NOT FULLTIME)
Hi, Could you take a look? fyi, rename from WebCore to blink landed a few ...
6 years, 5 months ago (2014-07-17 02:15:51 UTC) #1
JungJik
On 2014/07/17 02:15:51, Dai Mikurube wrote: > Hi, > > Could you take a look? ...
6 years, 5 months ago (2014-07-17 03:11:32 UTC) #2
Dai Mikurube (NOT FULLTIME)
On 2014/07/17 03:11:32, JungJik wrote: > On 2014/07/17 02:15:51, Dai Mikurube wrote: > > Hi, ...
6 years, 5 months ago (2014-07-17 03:40:32 UTC) #3
JungJik
On 2014/07/17 03:40:32, Dai Mikurube wrote: > On 2014/07/17 03:11:32, JungJik wrote: > > On ...
6 years, 5 months ago (2014-07-17 06:47:57 UTC) #4
Dai Mikurube (NOT FULLTIME)
Thanks! Committing.
6 years, 5 months ago (2014-07-17 07:43:20 UTC) #5
Dai Mikurube (NOT FULLTIME)
The CQ bit was checked by dmikurube@chromium.org
6 years, 5 months ago (2014-07-17 07:43:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/398933003/1
6 years, 5 months ago (2014-07-17 07:49:00 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 07:49:01 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-17 07:49:02 UTC) #9
Dai Mikurube (NOT FULLTIME)
Ah, sorry. I may need a lg tm by a full committer. But, it was ...
6 years, 5 months ago (2014-07-17 07:51:33 UTC) #10
Dai Mikurube (NOT FULLTIME)
Hoshi-san, Could you take a look?
6 years, 5 months ago (2014-07-17 07:52:07 UTC) #11
JungJik
On 2014/07/17 07:51:33, Dai Mikurube wrote: > Ah, sorry. I may need a lg tm ...
6 years, 5 months ago (2014-07-17 08:11:20 UTC) #12
hajimehoshi
lgtm
6 years, 5 months ago (2014-07-17 10:22:35 UTC) #13
Dai Mikurube (NOT FULLTIME)
Thanks!
6 years, 5 months ago (2014-07-17 10:22:58 UTC) #14
Dai Mikurube (NOT FULLTIME)
The CQ bit was checked by dmikurube@chromium.org
6 years, 5 months ago (2014-07-17 10:23:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/398933003/20001
6 years, 5 months ago (2014-07-17 10:23:58 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 10:25:26 UTC) #17
Message was sent while issue was closed.
Change committed as 283738

Powered by Google App Engine
This is Rietveld 408576698