Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 398903003: Revert of mac: Fix tab dragging visual bug in Yosemite. (reland) (Closed)

Created:
6 years, 5 months ago by agable
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Fix tab dragging visual bug in Yosemite. (reland) (https://codereview.chromium.org/393933003/) Reason for revert: Broke TestActivate and TestFullscreen on Mac 10.6 Tests (http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%282%29/builds/53658) Original issue's description: > mac: Fix tab dragging visual bug in Yosemite. (reland) > > -----------------Reland Description------------------ > Core animation was turned on in M35. The fullscreen window was not layer > backed, but should have been. This original CL exposed this bug. > > -----------------Original Description------------------ > In OSX 10.10+, all views must be added to the NSWindow's contentView. Some > views (like the tab strip and the profile icon) are placed on top of the title > bar and require special treatment. All other views are added as subviews of > 'chromeContentView' in TabWindowController. This allows tab dragging and > fullscreen logic to easily move the views that don't need special treatment. > > This CL also removes the instances where a VersionIndependentWindow's > contentView gets replaced by setContentView:. Instead, the 'chromeContentView' > gets passed around as a subview. This allows VersionIndependentWindow to remove > another of its internal hacks. > > Original CL link: https://codereview.chromium.org/379293003/ > BUG=392239 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283456 TBR=andresantoso@chromium.org,shess@chromium.org,erikchen@chromium.org NOTREECHECKS=true NOTRY=true BUG=392239 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -50 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_window.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 5 chunks +9 lines, -25 lines 0 comments Download
M chrome/browser/ui/cocoa/version_independent_window.mm View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
agable
Created Revert of mac: Fix tab dragging visual bug in Yosemite. (reland)
6 years, 5 months ago (2014-07-16 22:08:56 UTC) #1
erikchen
lgtm
6 years, 5 months ago (2014-07-16 22:09:42 UTC) #2
agable
The CQ bit was checked by agable@chromium.org
6 years, 5 months ago (2014-07-16 22:11:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/398903003/1
6 years, 5 months ago (2014-07-16 22:14:59 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 23:00:03 UTC) #5
Message was sent while issue was closed.
Change committed as 283563

Powered by Google App Engine
This is Rietveld 408576698