Context menu should not shows data: in heading

chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextmenu;
 
 import android.content.Context;
 import android.os.Build;
 import android.text.TextUtils;
 import android.view.ContextMenu;
 import android.view.MenuInflater;
 
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.UrlUtilities;
 import org.chromium.chrome.browser.search_engines.TemplateUrlService;
 
 /**
  * A {@link ContextMenuPopulator} used for showing the default Chrome context menu.
  */
 public class ChromeContextMenuPopulator implements ContextMenuPopulator {
     private final ChromeContextMenuItemDelegate mDelegate;
     private MenuInflater mMenuInflater;
+    private final String BLANK_URL = "about:blank";
 
     /**
      * Builds a {@link ChromeContextMenuPopulator}.
      * @param delegate The {@link ChromeContextMenuItemDelegate} that will be notified with actions
      *                 to perform when menu items are selected.
      */
     public ChromeContextMenuPopulator(ChromeContextMenuItemDelegate delegate) {
         mDelegate = delegate;
     }
 
     @Override
     public boolean shouldShowContextMenu(ContextMenuParams params) {
         return params != null && (params.isAnchor() || params.isEditable() || params.isImage()
                 || params.isSelectedText() || params.isVideo() || params.isCustomMenu());
     }
 
     @Override
     public void buildContextMenu(ContextMenu menu, Context context, ContextMenuParams params) {
-        if (params.isImage() && !TextUtils.isEmpty(params.getSrcUrl()))
-            menu.setHeaderTitle(params.getSrcUrl());
-        else if (!TextUtils.isEmpty(params.getLinkUrl()) )
-            menu.setHeaderTitle(params.getLinkUrl());
+        if (!TextUtils.isEmpty(params.getLinkUrl()) && !params.getLinkUrl().startsWith(BLANK_URL))

[Bernhard Bauer, 2014/07/28 07:51:18]

params.getLinkUrl().equals(BLANK_URL)?

[Jitu( very slow this week), 2014/07/28 08:01:49]

Done.

+                menu.setHeaderTitle(params.getLinkUrl());
 
         if (mMenuInflater == null) mMenuInflater = new MenuInflater(context);
 
         mMenuInflater.inflate(R.menu.chrome_context_menu, menu);
 
         menu.setGroupVisible(R.id.contextmenu_group_anchor, params.isAnchor());
         menu.setGroupVisible(R.id.contextmenu_group_image, params.isImage());
         menu.setGroupVisible(R.id.contextmenu_group_video, params.isVideo());
 
         if (mDelegate.isIncognito() || !mDelegate.isIncognitoSupported()) {
@@ skipping 68 matching lines @@
             mDelegate.onSearchByImageInNewTab();
         } else if (itemId == R.id.contextmenu_copy_image) {
             mDelegate.onSaveImageToClipboard(params.getSrcUrl());
         } else {
             assert false;
         }
 
         return true;
     }
 }