Context menu should not shows data: in heading

chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextmenu;
 
 import android.content.Context;
 import android.os.Build;
 import android.text.TextUtils;
 import android.view.ContextMenu;
@@ skipping 20 matching lines @@
     }
 
     @Override
     public boolean shouldShowContextMenu(ContextMenuParams params) {
         return params != null && (params.isAnchor() || params.isEditable() || params.isImage()
                 || params.isSelectedText() || params.isVideo() || params.isCustomMenu());
     }
 
     @Override
     public void buildContextMenu(ContextMenu menu, Context context, ContextMenuParams params) {
-        if (params.isImage() && !TextUtils.isEmpty(params.getSrcUrl()))
-            menu.setHeaderTitle(params.getSrcUrl());
+        if (params.isImage() && !TextUtils.isEmpty(params.getSrcUrl())) {
+            if (!params.getSrcUrl().startsWith("data:")) {

[Bernhard Bauer, 2014/07/21 10:19:28]

Hm, we probably shouldn't give the source URL precedence anyway. If there is a
link target, it's usually more interesting than the image source.

If we would give the link URL precedence (i.e. just swap the order of the two
if-statements), that would also solve this use case.

[Jitu( very slow this week), 2014/07/21 11:11:35]

Yes you are right... this will solve the problem.

But in some scenario the link URL may be an empty string for image contents. In
that case it will show "about:blank".

So to avoid that i have added like this.

Please let me know your comments in this.

[Bernhard Bauer, 2014/07/21 13:53:39]

Wait, are you sure you are not confusing the link text with the link URL? In
this situation:

<a href="http://example.com"><img src="http://example.com/image.png"></a>

The link *text* would be empty (because the contents of the link are just an
image), but the link *URL* would be http://example.com.

In the m.imgur.com example, about:blank is the link URL[*], but that has nothing
to do with the fact that the link text is empty, or that the link contains an
image.

Another way to think about it: What you are proposing in this CL would actually
show about:blank again if the image is a data URL (and the link target is
about:blank). That seems to contradict your assumption that we don't want to
show about:blank.

[*] Actually, it seems that the link URL is "javascript:;". I don't really know
why that becomes about:blank. If you want to investigate why, that would be
helpful (and would also get rid of the about:blank in the context menu!)

[Jitu( very slow this week), 2014/07/23 08:21:46]

Yes you are right..
Link URL is "javascript:" 

This become changed to about:blank while in this Below place while calling
FilterURL()

https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/fr...

And this is the exart place where it override to about:blank

https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...

Please let me know on this.

+                menu.setHeaderTitle(params.getSrcUrl());
+            } else {
+                menu.setHeaderTitle(params.getLinkUrl());
+            }
+        }
         else if (!TextUtils.isEmpty(params.getLinkUrl()) )
             menu.setHeaderTitle(params.getLinkUrl());
 
         if (mMenuInflater == null) mMenuInflater = new MenuInflater(context);
 
         mMenuInflater.inflate(R.menu.chrome_context_menu, menu);
 
         menu.setGroupVisible(R.id.contextmenu_group_anchor, params.isAnchor());
         menu.setGroupVisible(R.id.contextmenu_group_image, params.isImage());
         menu.setGroupVisible(R.id.contextmenu_group_video, params.isVideo());
@@ skipping 70 matching lines @@
             mDelegate.onSearchByImageInNewTab();
         } else if (itemId == R.id.contextmenu_copy_image) {
             mDelegate.onSaveImageToClipboard(params.getSrcUrl());
         } else {
             assert false;
         }
 
         return true;
     }
 }