Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Issue 398893003: Add back a static_cast<int32_t> to assembler-arm.cc to fix WebView build. (Closed)

Created:
6 years, 5 months ago by rmcilroy
Modified:
6 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, benm (inactive)
Project:
v8
Visibility:
Public.

Description

Add back a static_cast<int32_t> to assembler-arm.cc to fix WebView build. The WebView Mac builder is having trouble with resolving set_at_offset with an intptr_t argument to the correct overload. Add back the static_cast which was present before r22293 to resolve this. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/arm/assembler-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
Benedikt could you please take a look at this CL, thanks.
6 years, 5 months ago (2014-07-17 10:14:56 UTC) #1
Benedikt Meurer
LGTM
6 years, 5 months ago (2014-07-17 10:29:36 UTC) #2
rmcilroy
6 years, 5 months ago (2014-07-17 10:35:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698