[Android] Enable SB protection when --enable-spdy-proxy-auth is on.

[Android] Enable SB protection when --enable-spdy-proxy-auth is on.

The flag is used for testing purpose, and was left out.
Flywheel protection is on when flag is on or setting is on.

BUG=381896
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284002

[sky, 2014-07-17 03:28:36]

LGTM

https://codereview.chromium.org/398853003/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_io_data.cc (right):

https://codereview.chromium.org/398853003/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_io_data.cc:847: ||
CommandLine::ForCurrentProcess()->HasSwitch(
nit: || on previous line.

[Feng Qian, 2014-07-17 17:14:00]

The CQ bit was checked by feng@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:14:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/feng@chromium.org/398853003/20001

[commit-bot: I haz the power, 2014-07-17 18:56:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29821)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/34235)

[Feng Qian, 2014-07-17 19:04:48]

The CQ bit was checked by feng@chromium.org

[commit-bot: I haz the power, 2014-07-17 19:05:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/feng@chromium.org/398853003/40001

[Feng Qian, 2014-07-17 19:40:31]

The CQ bit was unchecked by feng@chromium.org

[Feng Qian, 2014-07-17 19:41:47]

The CQ bit was checked by feng@chromium.org

[commit-bot: I haz the power, 2014-07-17 19:44:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/feng@chromium.org/398853003/40001

[bolian, 2014-07-17 19:51:41]

+bengr

https://codereview.chromium.org/398853003/diff/40001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_io_data.cc (right):

https://codereview.chromium.org/398853003/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/profile_io_data.cc:846: return
data_reduction_proxy_enabled_.GetValue() ||
Can you use DataReductionProxySettings::IsDataReductionProxyEnabled?  It will be
hard to keep them in sync.

[Feng Qian, 2014-07-17 20:00:13]

https://codereview.chromium.org/398853003/diff/40001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_io_data.cc (right):

https://codereview.chromium.org/398853003/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/profile_io_data.cc:846: return
data_reduction_proxy_enabled_.GetValue() ||
On 2014/07/17 19:51:40, bolian wrote:
> Can you use DataReductionProxySettings::IsDataReductionProxyEnabled?  It will
be
> hard to keep them in sync.

There is an threading issue. Correct me if I am wrong.
DataReductionProxySettings::spdy_proxy_auth_enabled_ cannot be accessed from IO
thread. ProfileIOData::data_reduction_proxy_enabled_ can only be accessed from
IO thread.

[commit-bot: I haz the power, 2014-07-18 00:04:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[bolian, 2014-07-18 00:12:36]

https://codereview.chromium.org/398853003/diff/40001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_io_data.cc (right):

https://codereview.chromium.org/398853003/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/profile_io_data.cc:846: return
data_reduction_proxy_enabled_.GetValue() ||
I am just afraid someone may forget to change this when making changes  under
components/data_reduction_proxy. Ben will maintain the code there. I am fine as
long he is fine with this.

Ben, can you take a look?

[commit-bot: I haz the power, 2014-07-18 00:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 00:30:35]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Feng Qian, 2014-07-18 02:54:52]

The CQ bit was checked by feng@chromium.org

[commit-bot: I haz the power, 2014-07-18 02:55:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/feng@chromium.org/398853003/40001

[commit-bot: I haz the power, 2014-07-18 04:01:55]

Change committed as 284002