Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 398843002: Add the HTMLIFrameElement.allowFullscreen reflected attribute (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Add the HTMLIFrameElement.allowFullscreen reflected attribute http://whatwg.org/html#dom-iframe-allowfullscreen BUG=383813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M LayoutTests/fast/dom/boolean-attribute-reflection-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/boolean-attribute-reflection.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL. This is a Web-facing change, but it's trivial so I'm not sending an intent. ...
6 years, 5 months ago (2014-07-16 20:05:14 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-21 11:45:24 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-21 11:46:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/398843002/1
6 years, 5 months ago (2014-07-21 11:47:43 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 12:36:38 UTC) #5
Message was sent while issue was closed.
Change committed as 178555

Powered by Google App Engine
This is Rietveld 408576698