Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 398823010: move chrome_proxy test server to tools/chrome_proxy. (Closed)

Created:
6 years, 5 months ago by bolian
Modified:
6 years, 5 months ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

move chrome_proxy test server to tools/chrome_proxy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284595

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+-3 lines, -268 lines) Patch
A + tools/chrome_proxy/testserver/app.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/chrome_proxy/testserver/data/image1.png View Binary file 0 comments Download
A + tools/chrome_proxy/testserver/image/image1.png View Binary file 0 comments Download
A + tools/chrome_proxy/testserver/server.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/chrome_proxy/testserver/server_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/chromeproxy_testserver/OWNERS View 1 chunk +0 lines, -3 lines 1 comment Download
D tools/chromeproxy_testserver/app.yaml View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/chromeproxy_testserver/data/image1.png View Binary file 0 comments Download
D tools/chromeproxy_testserver/image/image1.png View Binary file 0 comments Download
D tools/chromeproxy_testserver/server.go View 1 chunk +0 lines, -159 lines 0 comments Download
D tools/chromeproxy_testserver/server_test.go View 1 chunk +0 lines, -99 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bolian
Hi Ben, Could you review this CL. It is super trivial. Thanks, Bolian
6 years, 5 months ago (2014-07-21 17:35:14 UTC) #1
bengr
https://codereview.chromium.org/398823010/diff/1/tools/chromeproxy_testserver/OWNERS File tools/chromeproxy_testserver/OWNERS (left): https://codereview.chromium.org/398823010/diff/1/tools/chromeproxy_testserver/OWNERS#oldcode1 tools/chromeproxy_testserver/OWNERS:1: bengr@chromium.org Why is there not a corresponding OWNERS file ...
6 years, 5 months ago (2014-07-21 17:37:12 UTC) #2
chromium-reviews
The one in the parent directory will cover that (tools/chrome_proxy/OWNERS). On Jul 21, 2014 10:37 ...
6 years, 5 months ago (2014-07-21 17:40:47 UTC) #3
bengr
lgtm
6 years, 5 months ago (2014-07-21 20:07:24 UTC) #4
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 5 months ago (2014-07-21 20:42:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/398823010/1
6 years, 5 months ago (2014-07-21 20:44:20 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 02:18:38 UTC) #7
Message was sent while issue was closed.
Change committed as 284595

Powered by Google App Engine
This is Rietveld 408576698