Automate host start up in browser test

remoting/webapp/browser_test/browser_test.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * @suppress {checkTypes}  By default, JSCompile is not run on test files.
  *    However, you can modify |remoting_webapp_files.gypi| locally to include
  *    the test in the package to expedite local development.  This suppress
  *    is here so that JSCompile won't complain.
@@ skipping 151 matching lines @@
   return browserTest.onUIMode(AppMode.CLIENT_HOST_NEEDS_UPGRADE).then(
     function() {
       // On fulfilled.
       browserTest.clickOnControl('host-needs-update-connect-button');
     }, function() {
       // On time out.
       return Promise.resolve();
     }).then(function() {
       return browserTest.onUIMode(AppMode.CLIENT_PIN_PROMPT);
     });
-}
+};
 
 browserTest.expectMe2MeError = function(errorTag) {
   var AppMode = remoting.AppMode;
   var Timeout = browserTest.Timeout;
 
   var onConnected = browserTest.onUIMode(AppMode.IN_SESSION, Timeout.None);
   var onFailure = browserTest.onUIMode(AppMode.CLIENT_CONNECT_FAILED_ME2ME);
 
   onConnected = onConnected.then(function() {
     return Promise.reject(
@@ skipping 35 matching lines @@
 browserTest.runTest = function(testClass, data) {
   try {
     var test = new testClass();
     browserTest.expect(typeof test.run == 'function');
     test.run(data);
   } catch (e) {
     browserTest.fail(e);
   }
 };
 
+browserTest.setupPIN = function(newPin) {
+  var AppMode = remoting.AppMode;
+  var HOST_SETUP_WAIT = 10000;
+  var Timeout = browserTest.Timeout;
+
+  return browserTest.onUIMode(AppMode.HOST_SETUP_ASK_PIN).then(function() {
+    document.getElementById('daemon-pin-entry').value = newPin;
+    document.getElementById('daemon-pin-confirm').value = newPin;
+    browserTest.clickOnControl('daemon-pin-ok');
+
+    var success = browserTest.onUIMode(AppMode.HOST_SETUP_DONE, Timeout.NONE);
+    var failure = browserTest.onUIMode(AppMode.HOST_SETUP_ERROR, Timeout.NONE);
+    failure.then(function(){

[Jamie, 2014/07/22 18:47:11]

I think you need to update failure, ie:

failure = failure.then...

[kelvinp, 2014/07/23 22:22:27]

Done.

+      return Promise.reject('Unexpected host setup failure');
+    });
+    return Promise.race([success, failure]);
+  }).then(function() {
+    console.log('browserTest: PIN Setup is done.')
+    browserTest.clickOnControl('host-config-done-dismiss');
+
+    // On Linux, we restart the host after changing the PIN, need to sleep
+    // for ten seconds before the host is ready for connection.
+    return base.Promise.sleep(HOST_SETUP_WAIT);
+  });
+};
+
+browserTest.ensureHostStartedWithPIN = function(pin) {
+  var AppMode = remoting.AppMode;
+  var HOST_RESTART_WAIT = 10000;
+  var Timeout = browserTest.Timeout;

[Jamie, 2014/07/22 18:47:11]

You don't seem to be using any of these definitions.

[kelvinp, 2014/07/23 22:22:27]

Done.

+
+  // Return if host is already
+  var startDaemonButton = document.getElementById('start-daemon');
+  if (startDaemonButton.offsetWidth != 0) {

[weitao, 2014/07/21 18:53:45]

Could you please add a comment here? What does the offsetWidth signify?

[Jamie, 2014/07/22 18:47:11]

It's an indication that the element is visible, but I don't think it's the right
approach here. The intent of this function is to ensure that the host is
enabled, not that the UI indicates that it is enabled (we should have a separate
test for that). I think it would be better (and self-documenting) to check the
state directly.

[kelvinp, 2014/07/23 22:22:27]

Done.

+    console.log('browserTest: Enabling remote connection.');
+    browserTest.clickOnControl('start-daemon');

[weitao, 2014/07/21 18:53:45]

Have you tested this on all platforms? I assume you will need to interact with
system dialogs (PrefPane for Mac and UAC for Windows).

[Jamie, 2014/07/22 18:47:11]

This is a good point. If we can't implement this cross-platform, is the any
value in making it work on Linux?

[kelvinp, 2014/07/23 22:22:27]

The code will work on Windows and Linux, as we are disabling UAC on windows on
the test machine.  I spoke to weitao and Anand and we will make the test work
for Windows and Linux working first.  I added a todo comment in the C++ code for
future support on Mac.

+  } else {
+    console.log('browserTest: Changing the PIN of the host to <' + pin + '>.' );
+    browserTest.clickOnControl('change-daemon-pin');
+  }
+  return browserTest.setupPIN(pin);
+};
+
+// Called by Browser Test in C++
+browserTest.ensureRemoteConnectionEnabled = function(pin) {
+  browserTest.ensureHostStartedWithPIN(pin).then(function(){
+    browserTest.automationController_.send(true);
+  }).catch(function(errorMessage){
+    console.error(errorMessage);
+    browserTest.automationController_.send(false);
+  });
+};
+
 browserTest.init();