Issue 398813005: [Sync] Rely on directory to decide which types need to be purged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398813005: [Sync] Rely on directory to decide which types need to be purged (Closed)

Created:
6 years, 5 months ago by Nicolas Zea

Modified:
6 years, 5 months ago

Reviewers:
rlarocque

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Sync] Rely on directory to decide which types need to be purged Preivously we relied on the SyncBackendRegistrar's last configured types to decide which types have been recently disabled. Now we just purge all disabled types that exist in the directory, as recorded by their progress markers (which should never be deleted unless the type has been purged). BUG=386778 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284283

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -27 lines)			Patch
M	chrome/browser/sync/glue/sync_backend_host_impl.cc	View	3 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc	View	15 chunks	+62 lines, -13 lines	0 comments	Download
M	sync/engine/syncer_unittest.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	sync/syncable/directory.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sync/syncable/directory.cc	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	sync/syncable/directory_unittest.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sync/syncable/syncable_unittest.cc	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	sync/test/engine/test_syncable_utils.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	sync/test/engine/test_syncable_utils.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/398813005/1

6 years, 5 months ago (2014-07-18 23:38:25 UTC) #4

Message was sent while issue was closed.

Change committed as 284283

Expand Messages | Collapse Messages