Cast Port Allocator Factory for PeerConnection

remoting/host/chromium_port_allocator_factory.h

Index: remoting/host/chromium_port_allocator_factory.h
diff --git a/remoting/host/chromium_port_allocator_factory.h b/remoting/host/chromium_port_allocator_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..5cdc012f608abca067159103ca2ffe0c5aabb64e
--- /dev/null
+++ b/remoting/host/chromium_port_allocator_factory.h
@@ -0,0 +1,46 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_CHROMIUM_PORT_ALLOCATOR_FACTORY_H_
+#define REMOTING_HOST_CHROMIUM_PORT_ALLOCATOR_FACTORY_H_
+
+#include "base/memory/ref_counted.h"
+#include "third_party/libjingle/source/talk/app/webrtc/peerconnectioninterface.h"
+
+namespace net {
+class URLRequestContextGetter;
+}  // namespace net
+
+namespace remoting {
+
+struct NetworkSettings;
+
+class ChromiumPortAllocatorFactory
+    : public webrtc::PortAllocatorFactoryInterface {
+ public:
+  static talk_base::scoped_refptr<webrtc::PortAllocatorFactoryInterface> Create(
+      const NetworkSettings& network_settings,
+      scoped_refptr<net::URLRequestContextGetter> url_request_context_getter);
+
+  // webrtc::PortAllocatorFactoryInterface implementation.
+  // Thought unspecified, the caller takes control of the returned

[Sergey Ulanov, 2014/07/21 17:43:13]

s/Thought/Though/? (or just remove "Thought unspecified,"). Also
s/control/ownership/

Or it's probably better to remove this comment altogether - ownership semantics
for a create method in a factory should be obvious without it.

[aiguha, 2014/07/21 18:50:39]

Agreed. I've removed the comment.

+  // PortAllocator.
+  virtual cricket::PortAllocator* CreatePortAllocator(
+      const std::vector<StunConfiguration>& stun_servers,
+      const std::vector<TurnConfiguration>& turn_configurations) OVERRIDE;
+
+ protected:
+  ChromiumPortAllocatorFactory(

[Sergey Ulanov, 2014/07/21 17:43:13]

This constructor should be private - it's called only by
ChromiumPortAllocatorFactory::Create().

[aiguha, 2014/07/21 18:50:39]

Actually, in Create(), a talk_base::RefCountedObject<CPAF> is being made, which
requires access to the base class' constructor and destructor, so these methods
can be protected at most. Making them private throws a compiler error.

[Sergey Ulanov, 2014/07/21 18:53:01]

Acknowledged.

+      const NetworkSettings& network_settings,
+      scoped_refptr<net::URLRequestContextGetter> url_request_context_getter);
+  virtual ~ChromiumPortAllocatorFactory();
+
+ private:
+  const NetworkSettings& network_settings_;
+  scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
+};

[Sergey Ulanov, 2014/07/21 17:43:13]

add DISALLOW_COPY_AND_ASSIGN(ChromiumPortAllocatorFactory).

[aiguha, 2014/07/21 18:50:39]

Done.

+
+}  // namespace remoting
+
+#endif  // REMOTING_HOST_CHROMIUM_PORT_ALLOCATOR_FACTORY_H_