Cast Port Allocator Factory for PeerConnection

remoting/host/cast_port_allocator_factory.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_CAST_PORT_ALLOCATOR_FACTORY_H_
+#define REMOTING_HOST_CAST_PORT_ALLOCATOR_FACTORY_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "net/url_request/url_request_context_getter.h"

[Sergey Ulanov, 2014/07/17 18:54:40]

Move this to .cc and forward-declare net::URLRequestContextGetter

[aiguha, 2014/07/17 19:39:59]

Done.

+#include "remoting/jingle_glue/chromium_port_allocator.h"

[Sergey Ulanov, 2014/07/17 18:54:40]

Move this to .cc

[aiguha, 2014/07/17 19:39:59]

Done.

+#include "third_party/libjingle/source/talk/app/webrtc/peerconnectioninterface.h"
+
+namespace cricket {
+class PortAllocator;

[Sergey Ulanov, 2014/07/17 18:54:40]

I don't think you need this - peerconnectioninterface.h should already declare
it.

[aiguha, 2014/07/17 19:39:59]

Done.

+}
+
+namespace remoting {
+
+struct NetworkSettings;
+
+class CastPortAllocatorFactory : public webrtc::PortAllocatorFactoryInterface {

[Sergey Ulanov, 2014/07/17 18:54:40]

Maybe call it ChromiumPortAllocatorFactory? it's not specific to cast, it just
allocates ChromiumPortAllocator instances.

(on the side note: I want to cry when I read AllocatorFactoryInterface, it's
factory factory interface essentially. bang head on the desk :-( )

[aiguha, 2014/07/17 19:39:59]

Done.

And haha, you're absolutely right. I thought the same while typing that out.
Someone should make a meme about that!

+ public:
+  static talk_base::scoped_refptr<webrtc::PortAllocatorFactoryInterface> Create(
+      const NetworkSettings& network_settings,
+      scoped_refptr<net::URLRequestContextGetter> url_request_context_getter);
+
+  // webrtc::PortAllocatorFactoryInterface implementation.
+  // Thought unspecified, the caller takes control of the returned
+  // PortAllocator.
+  virtual cricket::PortAllocator* CreatePortAllocator(
+      const std::vector<StunConfiguration>& stun_servers,
+      const std::vector<TurnConfiguration>& turn_configurations) OVERRIDE;
+
+ protected:
+  CastPortAllocatorFactory(
+      const NetworkSettings& network_settings,
+      scoped_refptr<net::URLRequestContextGetter> url_request_context_getter);
+  virtual ~CastPortAllocatorFactory();
+
+ private:
+  const NetworkSettings& network_settings_;
+  scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_HOST_CAST_PORT_ALLOCATOR_FACTORY_H_