Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 398803002: Context menu for image is not having any option to copy image URL. (Closed)

Created:
6 years, 5 months ago by ankit
Modified:
6 years, 5 months ago
Reviewers:
Bernhard Bauer, Ted C
CC:
chromium-reviews, AKVT
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Context menu for image is not having any option to copy image URL. There is no direct way to copy image url through context menu by which user can copy image url. Added an option in context menu for image to copy image url. BUG=394314 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283746

Patch Set 1 #

Total comments: 2

Patch Set 2 : Modified as per review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/android/java/res/menu/chrome_context_menu.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ankit
PTAL. Sorry for inconvenience. I have deleted previous issue raised bacause of Base URL problem. ...
6 years, 5 months ago (2014-07-16 13:19:31 UTC) #1
Bernhard Bauer
https://codereview.chromium.org/398803002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java File chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java (right): https://codereview.chromium.org/398803002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java#newcode81 chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:81: } This is from a different CL. https://codereview.chromium.org/398803002/diff/1/chrome/android/java/strings/android_chrome_strings.grd File ...
6 years, 5 months ago (2014-07-16 13:21:57 UTC) #2
ankit
@Bernhard PTAL new patch set.
6 years, 5 months ago (2014-07-16 13:36:31 UTC) #3
Bernhard Bauer
lgtm
6 years, 5 months ago (2014-07-16 13:44:04 UTC) #4
ankit
The CQ bit was checked by ankit2.kumar@samsung.com
6 years, 5 months ago (2014-07-17 03:42:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/398803002/20001
6 years, 5 months ago (2014-07-17 03:46:31 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 11:05:22 UTC) #7
Message was sent while issue was closed.
Change committed as 283746

Powered by Google App Engine
This is Rietveld 408576698