Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 398753004: [cros] Move User class to user_manager component. (Closed)

Created:
6 years, 5 months ago by Nikita (slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, yukishiino+watch_chromium.org, rginda+watch_chromium.org, davemoore+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nona+watch_chromium.org, kalyank, dbeam+watch-options_chromium.org, dkrahn+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, tfarina, eroman, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix build and deps #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : leave theme resource usage in chrome/ #

Patch Set 6 : add deps ( trybots) #

Total comments: 4

Patch Set 7 : nits #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1169 lines, -1558 lines) Patch
A + chrome/browser/browsing_data/DEPS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/first_run_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 2 3 4 5 6 6 chunks +13 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/file_manager/path_util.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/mount_path_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/first_run/first_run.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/crash_restore_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 6 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 2 5 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.h View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 2 9 chunks +24 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 11 chunks +21 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/signin/auth_sync_observer.cc View 1 2 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 9 chunks +18 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 1 2 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_login_flow.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_login_flow.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc View 1 2 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/mock_login_display.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/mock_login_display.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/user_flow.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/user_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 1 2 3 23 chunks +34 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc View 1 2 3 4 22 chunks +51 lines, -38 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_supervised_user_manager.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_supervised_user_manager.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_user_manager.h View 1 2 4 chunks +23 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_user_manager.cc View 1 2 3 4 10 chunks +53 lines, -32 lines 0 comments Download
M chrome/browser/chromeos/login/users/mock_user_manager.h View 1 2 6 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/users/mock_user_manager.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/supervised_user_manager.h View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/supervised_user_manager_impl.h View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc View 1 2 4 chunks +23 lines, -16 lines 0 comments Download
D chrome/browser/chromeos/login/users/user.h View 1 2 1 chunk +0 lines, -267 lines 0 comments Download
D chrome/browser/chromeos/login/users/user.cc View 1 2 1 chunk +0 lines, -321 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager.h View 1 2 6 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_impl.h View 1 2 11 chunks +36 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_impl.cc View 1 2 3 4 45 chunks +136 lines, -91 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_unittest.cc View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 24 chunks +48 lines, -41 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc View 9 chunks +18 lines, -33 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/net/onc_utils.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/net/onc_utils.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 7 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/policy_cert_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater.h View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/preferences_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.h View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.cc View 11 chunks +22 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/autotest_private/autotest_private_api.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_assets_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_garbage_collector_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/net/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/nss_context_chromeos_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/schema_registry_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/profiles/DEPS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/chromeos/manager_password_service.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/chromeos/manager_password_service_factory.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/chromeos/supervised_user_password_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/chromeos/supervised_user_password_service_factory.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 8 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/user_accounts_delegate_chromeos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 6 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 8 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/dbus/cryptohome_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager.gypi View 1 2 3 4 5 3 chunks +4 lines, -1 line 0 comments Download
M components/user_manager/DEPS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + components/user_manager/user.h View 1 2 3 4 13 chunks +58 lines, -51 lines 0 comments Download
A + components/user_manager/user.cc View 1 2 3 4 17 chunks +39 lines, -41 lines 0 comments Download
M components/user_manager/user_type.h View 1 2 3 4 5 6 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Nikita (slow)
antrim: whole CL OWNERS bauerb: chrome/browser/browsing_data/* chrome/browser/supervised_user/* mek: chrome/browser/extensions/* stevenjb: chrome/browser/notifications/* chromeos/dbus/* derat: chrome/browser/ui/ash/* willchan: ...
6 years, 5 months ago (2014-07-22 08:10:30 UTC) #1
dconnelly
chrome/browser/policy lgtm
6 years, 5 months ago (2014-07-22 08:33:28 UTC) #2
Bernhard Bauer
c/b/{browsing_data,supervised_user} LGTM
6 years, 5 months ago (2014-07-22 09:11:04 UTC) #3
Denis Kuznetsov (DE-MUC)
lgtm with nits https://chromiumcodereview.appspot.com/398753004/diff/100001/chrome/browser/chromeos/extensions/wallpaper_private_api.cc File chrome/browser/chromeos/extensions/wallpaper_private_api.cc (right): https://chromiumcodereview.appspot.com/398753004/diff/100001/chrome/browser/chromeos/extensions/wallpaper_private_api.cc#newcode518 chrome/browser/chromeos/extensions/wallpaper_private_api.cc:518: chromeos::WallpaperInfo info = {"", ash::WALLPAPER_LAYOUT_CENTER, nit: ...
6 years, 5 months ago (2014-07-22 10:56:55 UTC) #4
Nikita (slow)
https://chromiumcodereview.appspot.com/398753004/diff/100001/chrome/browser/chromeos/extensions/wallpaper_private_api.cc File chrome/browser/chromeos/extensions/wallpaper_private_api.cc (right): https://chromiumcodereview.appspot.com/398753004/diff/100001/chrome/browser/chromeos/extensions/wallpaper_private_api.cc#newcode518 chrome/browser/chromeos/extensions/wallpaper_private_api.cc:518: chromeos::WallpaperInfo info = {"", ash::WALLPAPER_LAYOUT_CENTER, On 2014/07/22 10:56:55, Denis ...
6 years, 5 months ago (2014-07-22 11:03:21 UTC) #5
mmenke
chrome/browser/net/ LGTM
6 years, 5 months ago (2014-07-22 14:28:21 UTC) #6
Daniel Erat
lgtm for c/b/ui/ash
6 years, 5 months ago (2014-07-22 14:45:25 UTC) #7
willchan no longer on Chromium
chrome/browser/profiles LGTM
6 years, 5 months ago (2014-07-22 14:47:17 UTC) #8
Marijn Kruisselbrink
*/extensions/* lgtm
6 years, 5 months ago (2014-07-22 18:22:11 UTC) #9
Nikita (slow)
On 2014/07/22 08:10:30, Nikita Kostylev wrote: > OWNERS > stevenjb: > chrome/browser/notifications/* > chromeos/dbus/* > ...
6 years, 5 months ago (2014-07-23 09:33:37 UTC) #10
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 5 months ago (2014-07-23 09:40:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/398753004/140001
6 years, 5 months ago (2014-07-23 09:41:25 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 14:52:11 UTC) #13
Message was sent while issue was closed. 
Change committed as 284925

Powered by Google App Engine
This is Rietveld 408576698