Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 398743002: Refactor verifyProtocolHandlerScheme() in NavigatorContentUtils.cpp (Closed)

Created:
6 years, 5 months ago by gyuyoung-inactive
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, philipj_slow, gasubic, fs, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, nessy, blink-reviews-bindings_chromium.org, gyuyoung.kim_webkit.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Refactor verifyProtocolHandlerScheme() in NavigatorContentUtils.cpp Remove redundant parameter in this function as well as rename the function name to verifyCustomHandlerScheme() to be sync with other helper function. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178264

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gyuyoung-inactive
6 years, 5 months ago (2014-07-16 08:56:13 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-16 09:12:14 UTC) #2
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-16 09:12:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/398743002/20001
6 years, 5 months ago (2014-07-16 09:13:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-16 09:51:42 UTC) #5
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-16 09:55:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/398743002/40001
6 years, 5 months ago (2014-07-16 09:55:38 UTC) #7
gyuyoung-inactive
Fix build break.
6 years, 5 months ago (2014-07-16 09:55:43 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 10:55:47 UTC) #9
Message was sent while issue was closed.
Change committed as 178264

Powered by Google App Engine
This is Rietveld 408576698