Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 398683005: Add routine for checking startTime when start the next utterance in handleSpeakingCompleted() (Closed)

Created:
6 years, 5 months ago by deejay
Modified:
6 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add routine for checking startTime when start the next utterance in handleSpeakingCompleted() Same functions are called twice when calling speak() function repeatedly like current issue. This issue is caused by asynchronous call. So, I add routine for checking startTime in handleSpeakingCompleted() that is for preventing call twice. BUG=367535 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/speech/SpeechSynthesis.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
deejay
PTAL.
6 years, 5 months ago (2014-07-16 11:58:00 UTC) #1
haraken
Can we add a test case?
6 years, 5 months ago (2014-07-16 12:01:46 UTC) #2
deejay
On 2014/07/16 12:01:46, haraken wrote: > Can we add a test case? I think that ...
6 years, 5 months ago (2014-07-16 15:17:21 UTC) #3
haraken
On 2014/07/16 15:17:21, djmix.kim wrote: > On 2014/07/16 12:01:46, haraken wrote: > > Can we ...
6 years, 5 months ago (2014-07-16 15:29:32 UTC) #4
deejay
The CQ bit was checked by djmix.kim@samsung.com
6 years, 5 months ago (2014-07-17 07:45:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djmix.kim@samsung.com/398683005/1
6 years, 5 months ago (2014-07-17 07:46:32 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 09:18:53 UTC) #7
Message was sent while issue was closed.
Change committed as 178344

Powered by Google App Engine
This is Rietveld 408576698