Issue 398643006: Really fix the arm builder bots by copying android_webview_build out one scope in toolchain.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398643006: Really fix the arm builder bots by copying android_webview_build out one scope in toolchain.gypi (Closed)

Created:
6 years, 5 months ago by rmcilroy

Modified:
6 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Really fix the arm builder bots by copying android_webview_build out one scope in toolchain.gypi Move android_webview_build variable to toolchain.gypi to fix arm builders. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22473

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	build/android.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
	M	build/toolchain.gypi	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

almost LGTM https://codereview.chromium.org/398643006/diff/20001/build/toolchain.gypi File build/toolchain.gypi (right): https://codereview.chromium.org/398643006/diff/20001/build/toolchain.gypi#newcode92 build/toolchain.gypi:92: 'android_webview_build%': '1',#<(android_webview_build)', s/'1',#// maybe?

6 years, 5 months ago (2014-07-18 11:26:32 UTC) #2

rmcilroy

https://codereview.chromium.org/398643006/diff/20001/build/toolchain.gypi File build/toolchain.gypi (right): https://codereview.chromium.org/398643006/diff/20001/build/toolchain.gypi#newcode92 build/toolchain.gypi:92: 'android_webview_build%': '1',#<(android_webview_build)', On 2014/07/18 11:26:32, Jakob wrote: > s/'1',#// ...

6 years, 5 months ago (2014-07-18 11:36:10 UTC) #3

rmcilroy

6 years, 5 months ago (2014-07-18 11:36:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r22473 (presubmit successful).

Expand Messages | Collapse Messages