Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 398623004: DevTools: Open new tab with correct url rather than navigate from default page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index beb26a6467134c8e698a2a1906f799cb24924308..0f1767e6f33b5928f3ae36ec9072d4642c409eff 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -336,6 +336,16 @@ int GetContentRestrictions(const Browser* browser) {
}
void NewEmptyWindow(Profile* profile, HostDesktopType desktop_type) {
+ NewWindow(profile, desktop_type, GURL());
+}
+
+Browser* OpenEmptyWindow(Profile* profile, HostDesktopType desktop_type) {
dgozman 2014/07/21 13:43:47 I think, this method is not used anymore.
+ return OpenWindow(profile, desktop_type, GURL());
+}
+
+void NewWindow(Profile* profile,
+ HostDesktopType desktop_type,
+ const GURL& url) {
bool incognito = profile->IsOffTheRecord();
PrefService* prefs = profile->GetPrefs();
if (incognito) {
@@ -352,7 +362,7 @@ void NewEmptyWindow(Profile* profile, HostDesktopType desktop_type) {
if (incognito) {
content::RecordAction(UserMetricsAction("NewIncognitoWindow"));
- OpenEmptyWindow(profile->GetOffTheRecordProfile(), desktop_type);
+ OpenWindow(profile->GetOffTheRecordProfile(), desktop_type, url);
} else {
content::RecordAction(UserMetricsAction("NewWindow"));
SessionService* session_service =
@@ -360,15 +370,17 @@ void NewEmptyWindow(Profile* profile, HostDesktopType desktop_type) {
profile->GetOriginalProfile());
if (!session_service ||
!session_service->RestoreIfNecessary(std::vector<GURL>())) {
- OpenEmptyWindow(profile->GetOriginalProfile(), desktop_type);
+ OpenWindow(profile->GetOriginalProfile(), desktop_type, url);
}
}
}
-Browser* OpenEmptyWindow(Profile* profile, HostDesktopType desktop_type) {
+Browser* OpenWindow(Profile* profile,
+ HostDesktopType desktop_type,
+ const GURL& url) {
Browser* browser = new Browser(
Browser::CreateParams(Browser::TYPE_TABBED, profile, desktop_type));
- AddTabAt(browser, GURL(), -1, true);
+ AddTabAt(browser, url, -1, true);
browser->window()->Show();
return browser;
}
« chrome/browser/ui/browser_commands.h ('K') | « chrome/browser/ui/browser_commands.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698