Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: chrome/browser/devtools/browser_list_tabcontents_provider.cc

Issue 398623004: DevTools: Open new tab with correct url rather than navigate from default page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_commands.h » ('j') | chrome/browser/ui/browser_commands.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/browser_list_tabcontents_provider.cc
diff --git a/chrome/browser/devtools/browser_list_tabcontents_provider.cc b/chrome/browser/devtools/browser_list_tabcontents_provider.cc
index 5d98f6ccc0ca43e86b76c4ee7b583622f66b31ec..07598fa21f995ad4564fffea43aa905f3078644c 100644
--- a/chrome/browser/devtools/browser_list_tabcontents_provider.cc
+++ b/chrome/browser/devtools/browser_list_tabcontents_provider.cc
@@ -105,14 +105,12 @@ BrowserListTabContentsProvider::CreateNewTarget(const GURL& url) {
BrowserList::GetInstance(host_desktop_type_);
WebContents* web_contents;
if (browser_list->empty()) {
- chrome::NewEmptyWindow(ProfileManager::GetLastUsedProfile(),
- host_desktop_type_);
+ chrome::NewWindow(ProfileManager::GetLastUsedProfile(),
+ host_desktop_type_, url);
if (browser_list->empty())
return scoped_ptr<DevToolsTarget>();
web_contents =
browser_list->get(0)->tab_strip_model()->GetActiveWebContents();
- web_contents->GetController().LoadURL(url,
- content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());
} else {
web_contents = chrome::AddSelectedTabWithURL(
browser_list->get(0),
« no previous file with comments | « no previous file | chrome/browser/ui/browser_commands.h » ('j') | chrome/browser/ui/browser_commands.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698