Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: chrome/browser/ui/browser_commands.h

Issue 398623004: DevTools: Open new tab with correct url rather than navigate from default page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_COMMANDS_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_COMMANDS_H_
6 #define CHROME_BROWSER_UI_BROWSER_COMMANDS_H_ 6 #define CHROME_BROWSER_UI_BROWSER_COMMANDS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "chrome/browser/devtools/devtools_toggle_action.h" 10 #include "chrome/browser/devtools/devtools_toggle_action.h"
(...skipping 29 matching lines...) Expand all
40 40
41 int GetContentRestrictions(const Browser* browser); 41 int GetContentRestrictions(const Browser* browser);
42 42
43 // Opens a new window with the default blank tab. 43 // Opens a new window with the default blank tab.
44 void NewEmptyWindow(Profile* profile, HostDesktopType desktop_type); 44 void NewEmptyWindow(Profile* profile, HostDesktopType desktop_type);
45 45
46 // Opens a new window with the default blank tab. This bypasses metrics and 46 // Opens a new window with the default blank tab. This bypasses metrics and
47 // various internal bookkeeping; NewEmptyWindow (above) is preferred. 47 // various internal bookkeeping; NewEmptyWindow (above) is preferred.
48 Browser* OpenEmptyWindow(Profile* profile, HostDesktopType desktop_type); 48 Browser* OpenEmptyWindow(Profile* profile, HostDesktopType desktop_type);
49 49
50 // Opens a new window with |url| opened in a tab.
51 void NewWindow(Profile* profile, HostDesktopType desktop_type, const GURL& url);
sky 2014/07/21 16:35:54 Can you use browser_navigator.h to create and navi
vkuzkokov 2014/08/05 17:12:09 Done.
52
53 // Opens a new window with |url| opened in a tab. This bypasses metrics and
54 // various internal bookkeeping; NewWindow (above) is preferred.
55 Browser* OpenWindow(Profile* profile,
56 HostDesktopType desktop_type,
57 const GURL& url);
58
59
50 // Opens a new window with the tabs from |profile|'s TabRestoreService. 60 // Opens a new window with the tabs from |profile|'s TabRestoreService.
51 void OpenWindowWithRestoredTabs(Profile* profile, 61 void OpenWindowWithRestoredTabs(Profile* profile,
52 HostDesktopType host_desktop_type); 62 HostDesktopType host_desktop_type);
53 63
54 // Opens the specified URL in a new browser window in an incognito session on 64 // Opens the specified URL in a new browser window in an incognito session on
55 // the desktop specified by |desktop_type|. If there is already an existing 65 // the desktop specified by |desktop_type|. If there is already an existing
56 // active incognito session for the specified |profile|, that session is re- 66 // active incognito session for the specified |profile|, that session is re-
57 // used. 67 // used.
58 void OpenURLOffTheRecord(Profile* profile, const GURL& url, 68 void OpenURLOffTheRecord(Profile* profile, const GURL& url,
59 chrome::HostDesktopType desktop_type); 69 chrome::HostDesktopType desktop_type);
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 void CreateApplicationShortcuts(Browser* browser); 170 void CreateApplicationShortcuts(Browser* browser);
161 void CreateBookmarkAppFromCurrentWebContents(Browser* browser); 171 void CreateBookmarkAppFromCurrentWebContents(Browser* browser);
162 bool CanCreateApplicationShortcuts(const Browser* browser); 172 bool CanCreateApplicationShortcuts(const Browser* browser);
163 bool CanCreateBookmarkApp(const Browser* browser); 173 bool CanCreateBookmarkApp(const Browser* browser);
164 174
165 void ConvertTabToAppWindow(Browser* browser, content::WebContents* contents); 175 void ConvertTabToAppWindow(Browser* browser, content::WebContents* contents);
166 176
167 } // namespace chrome 177 } // namespace chrome
168 178
169 #endif // CHROME_BROWSER_UI_BROWSER_COMMANDS_H_ 179 #endif // CHROME_BROWSER_UI_BROWSER_COMMANDS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698