athena: Handle WebContents created for new windows and create activities for these.

ui/views/controls/webview/webview.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/webview/webview.h"
 
 #include "content/public/browser/browser_accessibility_state.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/render_view_host.h"
@@ skipping 209 matching lines @@
   if (preferred_size_ == gfx::Size())
     return View::GetPreferredSize();
   else
     return preferred_size_;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // WebView, content::WebContentsDelegate implementation:
 
 void WebView::WebContentsFocused(content::WebContents* web_contents) {
   DCHECK(wc_owner_.get());

[flackr, 2014/07/18 18:15:08]

Do we need this check? We are violating this in athena because the subclass
AthenaWebView owns the WebContents, but it still makes perfect sense to focus
this view.

Alternately, would it make sense to have a virtual bool
OwnsWebContents(WebContents*) method which AthenaWebView could override to say
that it does indeed own the WebContents?

[miu, 2014/07/22 00:18:22]

The assumption is that WebView is only used as a WebContentsDelegate if it owns
the WebContents.  If AthenaWebView is supposed to work the same way, why not let
the base class (WebView) own the WebContents?

[flackr, 2014/07/22 00:27:37]

I'm guessing at the intentions of Stefan's CL, but we want to swap out the
WebContents to be able to suspend activities for memory management purposes.
That being said, perhaps I should just add a method which lets you swap out the
WebContents from a subclass so these checks which should pass still do.

   // The WebView is only the delegate of WebContentses it creates itself.
   OnWebContentsFocused(wc_owner_.get());
 }
 
 bool WebView::EmbedsFullscreenWidget() const {
-  DCHECK(wc_owner_.get());
   return embed_fullscreen_widget_mode_enabled_;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // WebView, content::WebContentsObserver implementation:
 
 void WebView::RenderViewDeleted(content::RenderViewHost* render_view_host) {
   NotifyMaybeTextInputClientChanged();
 }
 
@@ skipping 111 matching lines @@
   if (!contents) {
     content::WebContents::CreateParams create_params(
         browser_context, NULL);
     return content::WebContents::Create(create_params);
   }
 
   return contents;
 }
 
 }  // namespace views