Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 398593002: Rename built-in speech synthesis voice names. (Closed)

Created:
6 years, 5 months ago by David Tseng
Modified:
6 years, 5 months ago
Reviewers:
dmazzoni, zel
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename speech synthesis voice names. This fixes an issue where built-in voices duplicate voice names for US English Female TTS (by Google), an engine available from the webstore. This change depends on a Chrome OS change to make the same voice renaming changes. When out of sync, it appears the voices don't work. TEST=Manually verify every voice works (driven by ChromeVox). BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -32 lines) Patch
M chrome/browser/resources/chromeos/speech_synthesis/manifest.json View 1 chunk +10 lines, -16 lines 0 comments Download
M chrome/browser/resources/chromeos/speech_synthesis/manifest_guest.json View 1 chunk +10 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
David Tseng
6 years, 5 months ago (2014-07-15 21:19:36 UTC) #1
dmazzoni
lgtm
6 years, 5 months ago (2014-07-16 17:29:05 UTC) #2
David Tseng
The CQ bit was checked by dtseng@chromium.org
6 years, 5 months ago (2014-07-22 03:38:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/398593002/1
6 years, 5 months ago (2014-07-22 03:39:48 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 05:29:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 05:33:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/81421)
6 years, 5 months ago (2014-07-22 05:33:04 UTC) #7
David Tseng
+zelidrag for OWNERS.
6 years, 5 months ago (2014-07-22 16:16:44 UTC) #8
zel
lgtm
6 years, 5 months ago (2014-07-22 19:06:22 UTC) #9
David Tseng
The CQ bit was checked by dtseng@chromium.org
6 years, 5 months ago (2014-07-24 16:54:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/398593002/1
6 years, 5 months ago (2014-07-24 16:56:31 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 17:02:32 UTC) #12
Message was sent while issue was closed.
Change committed as 285302

Powered by Google App Engine
This is Rietveld 408576698