Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 398583003: Use new hash table template for compressing token streams. (Closed)

Created:
6 years, 5 months ago by koda
Modified:
6 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use new hash table template for compressing token streams. Uses the flexible low-level interface to minimize lookups and allocation. BUG=dart:13747 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38294

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -74 lines) Patch
M runtime/vm/object.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 5 chunks +81 lines, -74 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
koda
6 years, 5 months ago (2014-07-16 01:01:17 UTC) #1
siva
One question: Did you notice a size difference of the token stream after this change? ...
6 years, 5 months ago (2014-07-16 01:19:51 UTC) #2
koda
On 2014/07/16 01:19:51, siva wrote: > One question: > > Did you notice a size ...
6 years, 5 months ago (2014-07-16 03:27:36 UTC) #3
siva
Got it (forgot the code, it has been a while). LGTM.
6 years, 5 months ago (2014-07-16 17:23:57 UTC) #4
koda
6 years, 5 months ago (2014-07-16 17:39:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 manually as r38294 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698