Issue 398573007: Cleanup: remove IdentityAccountTracker (replaced by gaia::AccountTracker)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398573007: Cleanup: remove IdentityAccountTracker (replaced by gaia::AccountTracker) (Closed)

Created:
6 years, 5 months ago by Michael Courage

Modified:
6 years, 5 months ago

Reviewers:
fgorski

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup: remove IdentityAccountTracker (replaced by gaia::AccountTracker) This change replaces the IdentityAccountTracker with gaia::AccountTracker, which mostly does the same thing. The one functional consequence of this change is that the Identity API no longer keeps track of login token errors on its own. Instead it relies on the underlying token services to report errors to the user. BUG=364203 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283942

Patch Set 1 #

Patch Set 2 : rebase to ToT #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -1270 lines)			Patch
D	chrome/browser/extensions/api/identity/account_tracker.h	View		1 chunk	+0 lines, -153 lines	0 comments	Download
D	chrome/browser/extensions/api/identity/account_tracker.cc	View		1 chunk	+0 lines, -342 lines	0 comments	Download
D	chrome/browser/extensions/api/identity/account_tracker_unittest.cc	View		1 chunk	+0 lines, -729 lines	0 comments	Download
M	chrome/browser/extensions/api/identity/identity_api.h	View		4 chunks	+10 lines, -13 lines	0 comments	Download
M	chrome/browser/extensions/api/identity/identity_api.cc	View		7 chunks	+21 lines, -20 lines	0 comments	Download
M	chrome/browser/extensions/api/identity/identity_apitest.cc	View		5 chunks	+4 lines, -10 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/398573007/20001

6 years, 5 months ago (2014-07-17 23:22:05 UTC) #4

Message was sent while issue was closed.

Change committed as 283942

Expand Messages | Collapse Messages